Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status check names should use atlantis/$action instead of $action/atlantis #544

Closed
kenske opened this issue Mar 20, 2019 · 3 comments
Closed
Labels
feature New functionality/enhancement

Comments

@kenske
Copy link

kenske commented Mar 20, 2019

Any specific reason why you went with $action/atlantis instead of atlantis/$action?

This is a very minor nitpick, but in it's current form, the status checks appear on different parts of the status checks list. If they had atlantis in the name first, they would appear together in the list since they're sorted alphabetically. This is also what I've seen as the convention for most other app integrations (use the app name first, then the check type).

@lkysow
Copy link
Member

lkysow commented Mar 20, 2019

It should be changed. I was following some other apps but I think we should change it. PR's welcome!

@kenske
Copy link
Author

kenske commented Mar 20, 2019

Cool, I just was curious if there was a reason for it. I'll see if I can create a PR tonight.

@lkysow
Copy link
Member

lkysow commented Mar 29, 2019

Closed by #545

@lkysow lkysow closed this as completed Mar 29, 2019
@lkysow lkysow added the feature New functionality/enhancement label Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement
Projects
None yet
Development

No branches or pull requests

2 participants