Instance being replaced even when the machine_image is pinned

[kpocius]

machine_image pinning was introduced in #112 but even with the value set, the instance is being replaced when a new COS image comes out.

I believe the issue is in the locals:

  labels               = merge(var.labels, { "container-vm" = module.container.vm_container_label })

Didn't have time to dig into it, but I believe if we want to pass the correct label to the module, we need to parse machine_image. Alternatively we should update the way local.labels is generated.

Just raising an issue, in case someone wants to take a look. Might dig into it myself when I have a moment.

[kpocius]

@bschaatsbergen, this must have been a fluke -- I can no longer replicate the issue. Sorry for raising false alarms.

[bschaatsbergen]

Ah check, happy to see that it's not reproducible 😬 @kpocius

[dimisjim]

I think we need to reopen this. I am still experiencing this problem, which relates to the labels that are not properly pinned for the disks, even though machine_image is set as an input variable to the module.

The way I fixed it was with these changes: #149