Conversion to message-based packet encoding/decoding system

[Jameskmonger]

• write the core of the system

• convert all outbound messages

  • chat
    • chat message refactor: migrate chat-related packets to new packet system #96
    • private message refactor: migrate chat-related packets to new packet system #96
    • commands refactor: convert console packets to new message system #107
    • accept trade (96) refactor: convert trade and duel request acceptance packets to messages #115
    • accept duel (68) refactor: convert trade and duel request acceptance packets to messages #115
    • chat modes (32) refactor: convert "set chat options" packet to message #127
    • chat commands (248)
  • console commands refactor: convert console packets to new message system #107
  • interactions
    • player refactor: convert player interaction packets to new system #100
    • object refactor: convert object interaction packets to new system #98
    • npc refactor: convert NPC interaction packets to new system #99
    • widget item refactor: convert "interact with item on widget" packets to new message structure #109
    • world item (190, 244, 85, 65, 27) refactor: convert "world item interaction" outgoing packets #111
  • magic
    • on player (221) refactor: convert "cast magic on X" packets to message system #112
    • on npc (253) refactor: convert "cast magic on X" packets to message system #112
    • on object (225) refactor: convert "cast magic on X" packets to message system #112
    • on world item (168) refactor: convert "cast magic on X" packets to message system #112
    • on widget item (21) refactor: convert "cast magic on X" packets to message system #112
  • use item
    • on player (110) refactor: convert "use item on X" to message system #113
    • on npc (208) refactor: convert "use item on X" to message system #113
    • on object (24) refactor: convert "use item on X" to message system #113
    • on world item (172) refactor: convert "use item on X" to message system #113
    • on widget item (40) refactor: convert "use item on X" to message system #113
  • examines
    • on npc (247) refactor: convert "examine" packets to message system #117
    • on object (148) refactor: convert "examine" packets to message system #117
    • on world item (151?) refactor: convert "examine" packets to message system #117
    • on widget item (151?) refactor: convert "examine" packets to message system #117
  • friend/ignore
    • add to friends list (114) refactor: convert add/remove friends/ignore packets to message format #116
    • remove from friends list (255) refactor: convert add/remove friends/ignore packets to message format #116
    • add to ignore list (251) refactor: convert add/remove friends/ignore packets to message format #116
    • remove from ignore list (28) refactor: convert add/remove friends/ignore packets to message format #116
  • walking (73, 89, 236) refactor: convert walking to message system #145
  • widgets
    • click button (64) refactor: convert remaining outbound widget messages #128
    • click "please wait..." option (132) refactor: convert remaining outbound widget messages #128
    • confirm appearance change (231) refactor: convert remaining outbound widget messages #128
    • numeric input (238) refactor: convert various widget packets to new message system #120
    • name input (86) refactor: convert some more widget packets to message system #126
    • report abuse submit (202) refactor: convert some more widget packets to message system #126
    • drag item on widget (83) refactor: convert remaining outbound widget messages #128
    • drop item (29) refactor: convert remaining outbound widget messages #128
    • maybe closing widgets (176) refactor: convert remaining outbound widget messages #128
  • misc
    • click flashing tab icon (44) refactor: convert "click flashing tab icon" to message #129
  • anticheats? telemetry? who knows.. some of this stuff was in 317 and earlier
    • 121
    • 178
    • 13
    • 210
    • 160
    • 216
    • clicking something? is this an anticheat too? (234)
    • sending camera position? (58)
    • idle checker? (216)
  • unknown group, possibly cs2 related
    • 111
    • 9
    • 193
    • 53
    • 94
    • 213
    • 46
    • 130
    • 157
    • 84

---

• convert all inbound messages
  • updating
    • player updating refactor: convert player updating packet to new message system #105
      • refactor appearance block to be structured
    • npc updating (128) refactor: convert NPC updating to message system #125
    • reset actor animations (27) refactor: convert "reset all actor anims" to message #132
    • set local player position (129) refactor: convert "set local player position" to message #134
    • clear local player destination (233) refactor: convert "clear local destination" to message #138
  • region loading
    • standard (166) refactor: convert region-related inbound packets to message system #118
    • constructed (23) refactor: convert region-related inbound packets to message system #118
    • "clear map chunk" ? (64) refactor: convert region-related inbound packets to message system #118
    • reference position (254) refactor: convert region-related inbound packets to message system #118
  • cameras and cutscenes (7, 255, 253, 234) refactor: convert camera/cutscene packets to messages #137
  • varps/varbits (222, 2, 14, 72) refactor: convert varp/varbits packets to messages #130
  • cs2 (240)
  • widgets
    • set widget to hidden (115) refactor: convert some more widget packets to message system #126
    • containers
      • update items in container (12) refactor: convert widget item container packets to messages #122
      • clear items in container (174) refactor: convert widget item container packets to messages #122
      • update specific items on widget (214) refactor: convert widget item container packets to messages #122
    • set model (250) refactor: convert various widget packets to new message system #120
    • set npc chathead (160) refactor: convert various widget packets to new message system #120
    • set player chathead (210) refactor: convert various widget packets to new message system #120
    • set widget item model (120) refactor: convert various widget packets to new message system #120
    • set widget text (110) refactor: convert various widget packets to new message system #120
    • set widget text color (231) refactor: convert various widget packets to new message system #120
    • move widget child (3) refactor: convert various widget packets to new message system #120
    • set scroll position (182) refactor: convert various widget packets to new message system #120
    • animate widget model (24) refactor: convert various widget packets to new message system #120
    • rotate widget model (142) refactor: convert various widget packets to new message system #120
    • set widget model rotation speed (117) refactor: convert various widget packets to new message system #120
    • show widgets:
      • on screen (118) refactor: convert various widget packets to new message system #120
      • on tab and screen (84) refactor: convert various widget packets to new message system #120
      • unknown permanent chatbox widget (185)
      • fullscreen (195) refactor: convert various widget packets to new message system #120
      • chatbox (208) refactor: convert various widget packets to new message system #120
      • tab overlay (237) refactor: convert various widget packets to new message system #120
      • tab widget (140) refactor: convert various widget packets to new message system #120
      • walkable widget? (56) refactor: convert various widget packets to new message system #120
      • set report abuse widget (130) refactor: convert some more widget packets to message system #126
      • close all widgets (180) refactor: convert various widget packets to new message system #120
    • inputs
      • "enter amount" input (132) refactor: convert various widget packets to new message system #120
      • "enter name" widget (124) refactor: convert various widget packets to new message system #120
  • bulk packets refactor: convert packet bulking process to message #146
    • main coordinator (63) refactor: convert packet bulking process to message #146
    • play sound at position (9) refactor: convert "play sound at position" to message #140
    • spawn ground item (175) refactor: convert ground item packets to messages #139
    • spawn ground item [exclude some players] (19) refactor: convert ground item packets to messages #139
    • update ground item amount (99) refactor: convert ground item packets to messages #139
    • remove ground item (74) refactor: convert ground item packets to messages #139
    • rotate/animate object (49) refactor: convert object-related inbound packets to messages #144
    • spawn landscape object (241) refactor: convert object-related inbound packets to messages #144
    • remove landscape object (143) refactor: convert object-related inbound packets to messages #144
    • projectile (1) refactor: convert "create projectile" packet to message #143
    • player to object transformation (229) refactor: convert "transform player to object" into message #141
    • render gfx (202) refactor: convert "create gfx" packet to message #142
  • sound
    • play song refactor: migrate audio-related packets to new packet system #94
    • play sound refactor: migrate audio-related packets to new packet system #94
    • play quick song refactor: migrate audio-related packets to new packet system #94
  • chat
    • chatbox message refactor: migrate chat-related packets to new packet system #96
    • private message refactor: migrate chat-related packets to new packet system #96
    • friend log in/out refactor: migrate chat-related packets to new packet system #96
    • chat mode settings refactor: migrate chat-related packets to new packet system #96
    • update ignore list (211) refactor: convert 3 misc packets to message system #123
  • console refactor: convert console packets to new message system #107
  • misc
    • log out refactor: convert logout and stat update packets to new message format #106
    • carry weight refactor: convert logout and stat update packets to new message format #106
    • run energy refactor: convert logout and stat update packets to new message format #106
    • skill level/xp refactor: convert logout and stat update packets to new message format #106
    • player options (223) refactor: convert 3 misc packets to message system #123
    • system update (116) refactor: convert some misc packets to new message system #119
    • set current open tab (6) refactor: convert some misc packets to new message system #119
    • minimap state (235) refactor: convert some misc packets to new message system #119
    • multi combat (48) refactor: convert some misc packets to new message system #119
    • flash sidebar icon (88) refactor: convert 3 misc packets to message system #123
    • set hint icon (186) refactor: convert "set hinticon" packet to message #133
  • unknown
    • anticheat or something? (58)

---

TODO add more as I find them

[Promises]

Could you also list unknown packets, and the ids for the known ones? could help figuring out the rest?

[Jameskmonger]

@Promises good suggestion. I've listed all outgoing opcodes for any packets which aren't done. Some of them are in the list, others I don't know what they do yet.

[Jameskmonger]

The main piece of this work is done 🎉

I'll leave this ticket open for now as there are some nice-to-haves left (cs2, anticheat etc).