Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts-lit-plugin works with other html template literal too #370

Open
darcyparker opened this issue Sep 20, 2024 · 0 comments
Open

ts-lit-plugin works with other html template literal too #370

darcyparker opened this issue Sep 20, 2024 · 0 comments

Comments

@darcyparker
Copy link

I just tried https://github.com/runem/lit-analyzer/tree/master/packages/ts-lit-plugin with https://github.com/WebReflection/uhtml and it works well for their html template literals too. I suspect it works with others too.

I am using it with neovim's lsp. All I had to do was add it to my tsconfig.

Perhaps you'd consider adding this to your documentation? And (unlikely) consider changing the name to indicate it works with other html literal APIs too?

I'd also like to add a minor enhancement to help with svg template literals.

html`<svg width="${widthPx}" height="${heightPx}"> ... <svg>` //works for `<svg>` element and its attributes, but not the child svg elements
svg`<svg width="${widthPx}" height="${heightPx}"> ... <svg>` //doesn't work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant