Skip to content
This repository has been archived by the owner on Jan 25, 2020. It is now read-only.

add typescript 2.3 support #11

Open
prabirshrestha opened this issue May 31, 2017 · 4 comments
Open

add typescript 2.3 support #11

prabirshrestha opened this issue May 31, 2017 · 4 comments

Comments

@prabirshrestha
Copy link
Contributor

No description provided.

@AmebaBrain
Copy link

I don't know if this relates to this, but after specifying custom path to tsserverlibrary.js library I get such errors (I translated messages to english for convenience)

let g:tscompletejob_custom_tsserverlibrary = "/path/to/tsserverlibrary.js"

"app.component.ts" 16L, 370C записаний
Error during executing function 47_BufWritePostHook[4]..47_UpdateErrors[15]..47_CacheErrors[39]..278[1]..277[24]..SyntaxCheckers_typescript_tscomplet
ejob_GetLocList[1]..tscompletejob#get_qfixlist[5]..tscompletejob#wait_response[6]..95_waitResponse[4]..95_onErr:
рядок 1:
' at Function.Module._load (module.js:505:3)'
Error during executing function 47_BufWritePostHook[4]..47_UpdateErrors[15]..47_CacheErrors:
рядок 39:
E170: Missed :endfor
Error during executing function 47_BufWritePostHook[4]..47_UpdateErrors:
рядок 15:
E171: Missed :endif

My TS version typescript: 2.6.2

With default provided library plugin seems working. I just start to use it, after switching from tsuquyomi.

Thanks for plugin

@AmebaBrain
Copy link

@runoshun

Could you please clarify where do you get tsswrapper200.js, tsswrapper210.js files?
Are they manually prepared by you or they could be grabbed somewhere?
I want update TS support for 2.6.2 and was wondered if such files are in public access

Thank you

@runoshun
Copy link
Owner

runoshun commented Feb 12, 2018

@prabirshrestha @AmebaBrain
I added support for typescript 2.3 or higher. (bdcecc5).
Please update tscompletejob plugin.

The bundled typescript version is updated to 2.7.1 . If you need to use another version, please set g:tscompletejob_custom_tsserver. (g:tscomplete_job_custom_tsserverlibrary can not be used for ts2.3 or higher)

@AmebaBrain
Copy link

@runoshun

I've updated plugin and typescript by executing npm install in node_modules\typescript folder. I see now that tsc version is 2.7.1

~/.vim/bundle/tscompletejob/autoload/tscompletejob/tsswrapper/node_modules/.bin (master) $ ./tsc --version
Version 2.7.1

Big thanks for that!

Now I can edit *.ts files having typescript 2.6.2 installed for my project and vim saves files already without an error.

Nevertheless, if I try to use :vimgrep /pattern/ **/* to search for pattern in my project files I still get a lot of errors from tscompletejob plugin
(note: error description with my translation from Ukrainian)

E716: Such key is absent in dictionary: -1
E15: Incorrect expression/statement: self.buffers[l:key].tmpfile
Error occured during execution function tscompletejob#add_buffer[3]..136_ensureReload[1]..138_isOpened:

I suppress errors via :silent! vimgrep /pattern/ **/* and it's not a blocker. But may be you can have a look.

Thanks again for upgrade

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants