Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configuration parsing #9

Open
rupert opened this issue Oct 16, 2018 · 0 comments
Open

Remove configuration parsing #9

rupert opened this issue Oct 16, 2018 · 0 comments

Comments

@rupert
Copy link
Owner

rupert commented Oct 16, 2018

At the moment we use the find_project_root, FileMode.from_configuration, and format_file_contents functions from the black package.

At the moment if a new configuration option is added to black, our call to FileMode.from_configuration will break as it will be missing an argument. It would be nice if black exposed a function to create a FileMode object from a pyproject.toml configuration file. Then we could pass the FileMode object to the format_file_contents function without worrying about the exact configuration options.

See --skip-numeric-underscore-normalization in #6

@rupert rupert changed the title Cleaner integration with black Remove configuration parsing Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant