Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adopting the x264 crate. #6

Open
quadrupleslap opened this issue Jan 8, 2018 · 6 comments
Open

Consider adopting the x264 crate. #6

quadrupleslap opened this issue Jan 8, 2018 · 6 comments

Comments

@quadrupleslap
Copy link

I'm not very familiar with x264, but I needed it for a project I was working on, so I made a high-level wrapper of it over here (docs). If you think the crate is a decent enough safe abstraction, would you mind adopting it? Thanks for considering it!

@quadrupleslap
Copy link
Author

Bump? It now works without libstd, and supports UYVY/YUYV too!

@lu-zero
Copy link
Member

lu-zero commented Apr 7, 2018

Since this repo existed before your hand-made version, why you didn't contribute to it instead?

@quadrupleslap
Copy link
Author

It wasn't on crates.io, so I didn't know it existed! :P

@lu-zero
Copy link
Member

lu-zero commented Apr 9, 2018

I need some time to read all your work, I'm quite sure we could try to deduplicate at least some of the effort, I would keep the sys crate since the automated bindings would help who would like to build different abstractions.

@quadrupleslap
Copy link
Author

Yeah, no problem, I'm using the x264-sys crate, too - if the build script misled you, that's just for detecting UYVY support, it doesn't do any linking or bindings generation.

@lu-zero
Copy link
Member

lu-zero commented Sep 17, 2019

Oh wow, I got really sidetracked, I'm going to publish a new version of the -sys crate soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants