You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses issue #386 by providing a struct IndexView analogous to HeaderView.
Since I'm not particularly well versed in interfacing with C and the htslib API, I'm a bit unsure if this is "the correct way" to handle this. There's no corresponding implementation for Clone yet, and I'm not sure what the point of the owned field of HeaderView is, since it does not seem to be modified anywhere.
This still needs some testcases, a simple one should be the one from the referenced issue.
I've added an unpolished translation of the slow_idxstats method from samtools bam_index.c, which should be used in case of CRAM (and SAM) indexed files.
Nice work! If I remember correctly, the owned flag was for destroying the header view, which is not always what you want. But I don't recall the details anymore and don't have the time to check the code. However, this one looks good to me for now.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #386 by providing a struct
IndexView
analogous toHeaderView
.Since I'm not particularly well versed in interfacing with C and the htslib API, I'm a bit unsure if this is "the correct way" to handle this. There's no corresponding implementation for
Clone
yet, and I'm not sure what the point of theowned
field ofHeaderView
is, since it does not seem to be modified anywhere.This still needs some testcases, a simple one should be the one from the referenced issue.