Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement Drop for faidx::Reader, destroying the fai handle #391

Merged
merged 2 commits into from
May 16, 2023

Conversation

tedil
Copy link
Member

@tedil tedil commented May 15, 2023

It seems the faidx::Reader had no implementation for Drop, hence not correctly handling its inner htslib faidx handle. This might fix #390.

Todo:

  • add a testcase opening and subsequently dropping many faidx handles

@coveralls
Copy link

coveralls commented May 15, 2023

Pull Request Test Coverage Report for Build 4978036075

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 79.307%

Files with Coverage Reduction New Missed Lines %
src/bam/record.rs 1 76.33%
Totals Coverage Status
Change from base Build 4959211191: -0.02%
Covered Lines: 2334
Relevant Lines: 2943

💛 - Coveralls

@johanneskoester johanneskoester merged commit 0e6d6ac into master May 16, 2023
@johanneskoester johanneskoester deleted the drop-faidx-handle branch May 16, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

faidx file not closed when Reader goes out of scope: Too many open files
3 participants