Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoS protection outgoing message queue #19

Open
tamasblummer opened this issue Jan 25, 2019 · 3 comments
Open

DoS protection outgoing message queue #19

tamasblummer opened this issue Jan 25, 2019 · 3 comments

Comments

@tamasblummer
Copy link
Contributor

tamasblummer commented Jan 25, 2019

The outgoing message queue (P2PControl) is not bounded, therefore easy to DoS the node by asking e.g. for many blocks and not consuming themm, this would consume all RAM with the queue. Limiting the queue would stop unrelated processing once the queue is full and give rise to yet another DoS vulnarebility. Ideally outgoing messages should be just dropped if a peer did not consume previous fast enough, after all this is not our problem.

@TigerInYourDream
Copy link

HI, will it work in a few days? I asked this question a month ago. I want to find an spv client in rust that worked.

@tamasblummer
Copy link
Contributor Author

It works. Eg. used in https://github.com/defiads/defiads to connect to two p2p network bitcoin and defiad's own.

@TigerInYourDream
Copy link

It works. Eg. used in https://github.com/defiads/defiads to connect to two p2p network bitcoin and defiad's own.

Thanks for the reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants