Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueKind is a Value, not a Kind #590

Open
epage opened this issue Oct 23, 2024 · 4 comments
Open

ValueKind is a Value, not a Kind #590

epage opened this issue Oct 23, 2024 · 4 comments

Comments

@epage
Copy link
Contributor

epage commented Oct 23, 2024

Kinds in Rust API design are basically variant discriminants. This stores the underlying value.

@polarathene
Copy link
Collaborator

If refactoring, this PR is likely related: #472

It's goal was to centralize conversion from config.

@epage
Copy link
Contributor Author

epage commented Oct 24, 2024

imo several of those commits seem stand on their own enough that splitting them out into individual PRs would be a big help for moving getting those merged more quickly.

@polarathene
Copy link
Collaborator

Yes I understand, I still would like to pick it back up, especially with project maintenance being restored.

I just overcommitted myself over the past year, burned out and playing catchup. December is probably the earliest I'd have time to allocate to revisiting my contributions here.

@epage
Copy link
Contributor Author

epage commented Oct 24, 2024

Thats perfectly fine! I'm playing catch up with issues and PRs from months ago :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants