Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV break due to is_terminal 0.4.8 #273

Closed
qinsoon opened this issue Jul 4, 2023 · 1 comment
Closed

MSRV break due to is_terminal 0.4.8 #273

qinsoon opened this issue Jul 4, 2023 · 1 comment

Comments

@qinsoon
Copy link

qinsoon commented Jul 4, 2023

env_logger 0.10.0 uses is_terminal 0.4.0 and names its MSRV as 1.60, but the new release of is_terminal 0.4.8 increases their MSRV to 1.63 (https://github.com/sunfishcode/is-terminal/blob/f720869b4796297d0c1814fe99a7914bf9391315/Cargo.toml#L16). So env_logger 0.10.0 can only build with Rust 1.63+ at the moment.

@epage
Copy link
Contributor

epage commented Jul 4, 2023

env_loggers dependency on is_terminal is

is-terminal = { version = "0.4.0", optional = true }

This means env_logger can be used with any version of is-terminal, from 0.4.0 to 0.4.8.

So for users who want the lower end of our MSRV, they can choose older versions of is-terminal to meet their MSRV needs. This will be made easier when rust-lang/cargo#9930 is implemented.

This does require checking in your lockfile. In rust-lang/cargo#8728, I have proposed that the cargo team starts recommending it be checked in, officially. A lot of us are already doing so.

Apparently, there is a common suggestion that packages set an upper bound for what is compatible. rust-lang/cargo#8728 talks a little about why that is bad and in rust-lang/cargo#12323, we are updating cargo's documentation to warn people away from it.

@epage epage closed this as not planned Won't fix, can't repro, duplicate, stale Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants