-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSRV break due to is_terminal 0.4.8 #273
Comments
is-terminal = { version = "0.4.0", optional = true } This means So for users who want the lower end of our MSRV, they can choose older versions of This does require checking in your lockfile. In rust-lang/cargo#8728, I have proposed that the cargo team starts recommending it be checked in, officially. A lot of us are already doing so. Apparently, there is a common suggestion that packages set an upper bound for what is compatible. rust-lang/cargo#8728 talks a little about why that is bad and in rust-lang/cargo#12323, we are updating cargo's documentation to warn people away from it. |
env_logger 0.10.0
usesis_terminal 0.4.0
and names its MSRV as 1.60, but the new release ofis_terminal 0.4.8
increases their MSRV to 1.63 (https://github.com/sunfishcode/is-terminal/blob/f720869b4796297d0c1814fe99a7914bf9391315/Cargo.toml#L16). Soenv_logger 0.10.0
can only build with Rust 1.63+ at the moment.The text was updated successfully, but these errors were encountered: