Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Road to 1.0 #37

Open
thejpster opened this issue Aug 22, 2020 · 2 comments
Open

Road to 1.0 #37

thejpster opened this issue Aug 22, 2020 · 2 comments

Comments

@thejpster
Copy link
Member

What do we need to do to put out a 1.0 release? One assumes we at least need an embedded-hal 1.0 (rust-embedded/embedded-hal#177)
@kellda
Copy link
Contributor

kellda commented Mar 22, 2022

I think something that should be done on the next breaking release is using the "sealed trait" pattern for *Pin traits.

I.e. having a private trait Sealed and requiring *Pin: Sealed. This would be better than (and should be done instead of) writing "DO NOT IMPLEMENT THIS TRAIT" in the docs.

Btw, why are internal macros such as uart_hal_macro and uart_pin_macro exposed in the API ?

@thejpster
Copy link
Member Author

Happy to see a PR.

Macros I think are shared between tm4c123 and 129 and hence exported from tm4c common.

@kellda kellda mentioned this issue Jun 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thejpster @kellda