appease clippy

Author: adamgreig

cortex-m/src/lib.rs

@@ -17,10 +17,10 @@
 //! are:
 //!
 //! - Reduced overhead. FFI eliminates the possibility of inlining so all operations include a
-//! function call overhead when `inline-asm` is not enabled.
+//!   function call overhead when `inline-asm` is not enabled.
 //!
 //! - Some of the `register` API only becomes available only when `inline-asm` is enabled. Check the
-//! API docs for details.
+//!   API docs for details.
 //!
 //! The disadvantage is that `inline-asm` requires a Rust version at least 1.59 to use the `asm!()`
 //! macro. In the future 0.8 and above versions of `cortex-m`, this feature will always be enabled.

cortex-m/src/peripheral/scb.rs

@@ -646,10 +646,7 @@ impl SCB {
     /// a runtime-dependent `panic!()` call.
     #[inline]
     pub unsafe fn invalidate_dcache_by_slice<T>(&mut self, slice: &mut [T]) {
-        self.invalidate_dcache_by_address(
-            slice.as_ptr() as usize,
-            slice.len() * core::mem::size_of::<T>(),
-        );
+        self.invalidate_dcache_by_address(slice.as_ptr() as usize, core::mem::size_of_val(slice));
     }
 
     /// Cleans D-cache by address.
@@ -732,10 +729,7 @@ impl SCB {
     /// to main memory, overwriting whatever was in main memory.
     #[inline]
     pub fn clean_dcache_by_slice<T>(&mut self, slice: &[T]) {
-        self.clean_dcache_by_address(
-            slice.as_ptr() as usize,
-            slice.len() * core::mem::size_of::<T>(),
-        );
+        self.clean_dcache_by_address(slice.as_ptr() as usize, core::mem::size_of_val(slice));
     }
 
     /// Cleans and invalidates D-cache by address.

cortex-m/src/register/primask.rs

@@ -41,17 +41,21 @@ pub fn read() -> Primask {
 /// Reads the entire PRIMASK register
 /// Note that bits [31:1] are reserved and UNK (Unknown)
 #[inline]
+#[cfg(cortex_m)]
 pub fn read_raw() -> u32 {
     let r: u32;
-    #[cfg(cortex_m)]
-    unsafe {
-        asm!("mrs {}, PRIMASK", out(reg) r, options(nomem, nostack, preserves_flags))
-    };
-    #[cfg(not(cortex_m))]
-    panic!("cannot read PRIMASK on non-cortex-m platform");
+    unsafe { asm!("mrs {}, PRIMASK", out(reg) r, options(nomem, nostack, preserves_flags)) };
     r
 }
 
+/// Reads the entire PRIMASK register
+/// Note that bits [31:1] are reserved and UNK (Unknown)
+#[inline]
+#[cfg(not(cortex_m))]
+pub fn read_raw() -> u32 {
+    panic!("cannot read PRIMASK on non-cortex-m platform");
+}
+
 /// Writes the entire PRIMASK register
 /// Note that bits [31:1] are reserved and SBZP (Should-Be-Zero-or-Preserved)
 ///