Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pwm enable and disable methods only work for channels #182

Open
justacec opened this issue Jan 26, 2020 · 0 comments
Open

Pwm enable and disable methods only work for channels #182

justacec opened this issue Jan 26, 2020 · 0 comments

Comments

@justacec
Copy link

In a review of the Pwm trait, I noticed that there is no way to disable a timer completely. The existing enable and disable methods are designed for specific channels. I think there ought to be some method to generally disable the entire timer. I think that the current methods should be re-purposed as the generate timer disable/enable and then two new methods could be introduced to support channel enable/disable. These new methods could be called enable_channel/disable_channel. The remaining methods would not need to be altered as they are understood by context (ie, one cannot specify the duty for all of the channels at once, it is understood that is a per-channel operation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants