Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid ssl/tls certificates #1

Closed
caemor opened this issue Sep 13, 2018 · 3 comments
Closed

invalid ssl/tls certificates #1

caemor opened this issue Sep 13, 2018 · 3 comments

Comments

@caemor
Copy link

caemor commented Sep 13, 2018

Both:

Basically they both seems to use the *.github.com/*github.io certificates but as the domain isn't any of the subdomains of github anymore this leads to an error/warning in most browsers.

E.g.

embedonomicon.rust-embedded.org uses an invalid security certificate. 

The certificate is only valid for the following names: www.github.com, *.github.io, *.githubusercontent.com, *.github.com, github.com, github.io, githubusercontent.com 

Error code: SSL_ERROR_BAD_CERT_DOMAIN
@nastevens
Copy link
Member

With the reorg per rust-embedded/wg#208, all docs are now hosted under https://docs.rust-embedded.org, and TLS certs are lined up correctly for that. However, the following will still fail if you try to go directly to the https version - this is because the following pages actually host a HTTP redirect and there are certificate issues going from AWS to Github:

I think at this point the right way to fix this will be to get TLS certs for those specific domains (probably through LetsEncrypt) and then run a lambda at those endpoints to do the HTTP redirect.

@caemor
Copy link
Author

caemor commented Nov 14, 2018

Should I leave this open to track the further steps in the future or can I close it?

@nastevens
Copy link
Member

I created #10 to track the more specific issue, so this can be closed. Thanks for reporting this originally!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants