Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find more maintainers for ethabi #207

Open
vkgnosis opened this issue Mar 5, 2021 · 9 comments
Open

Find more maintainers for ethabi #207

vkgnosis opened this issue Mar 5, 2021 · 9 comments

Comments

@vkgnosis
Copy link
Member

vkgnosis commented Mar 5, 2021

The ethabi crate in particular is important to the rust ethereum ecosystem but it has many outstanding issues and PRs which has caused it to for example be forked with more patches applied like at https://github.com/gakonst/ethabi and I have personally also needed those patches for https://github.com/gnosis/ethcontract-rs and I imagine rust-web3 would benefit too.

My guess is (and please correct me if wrong) that there is currently no driving force to push bigger changes like abiv2 support. Could we find more maintainers? Who currently has write access to the repo? How should we agree on what can be merged?

Some people from Gnosis including myself probably have some capacity to review and make PRs.

@vkgnosis
Copy link
Member Author

vkgnosis commented Mar 9, 2021

@gakonst tagging you because I linked your fork but that probably doesn't give you a notification. Would getting ethabi to roughly the state of your fork allow you to move back to using it?

@vkgnosis
Copy link
Member Author

@vorot93 @kirk-baird you are the two members I see of the rust-ethereum organization so I thought I'd ping you directly.

@kirk-baird
Copy link
Member

Hey, you're right seems this repo hasn't had PRs merged for a while. I'm not sure who was previously in charge of this repo.

I haven't worked on this repo before I'm in the rust-ethereum org for work on Eth2. Though I do a lot of work on solidity and Eth1 so have a solid understanding of ABI's and rust. I'm happy to do review some PRs though won't have time for active development of significant features e.g. ABIv2.

@vkgnosis
Copy link
Member Author

Update: We've added @nlordell and myself as maintainers for this crate and we're planning on merging outstanding PRs. If other people are interested, feel free to write here.

@gakonst
Copy link
Contributor

gakonst commented Mar 18, 2021

That's great! If all the patches from my fork were applied and you folks take over maintaining it, I'd be happy to switch to the original. I am rebased on master, so should be easy.

@gakonst
Copy link
Contributor

gakonst commented Mar 31, 2021

@vkgnosis thanks for the work so far! Curious if you're planning on cutting a new minor release soon?

@nlordell
Copy link
Contributor

I think we're trying to figure out Crates.io access 🙈.

@gakonst
Copy link
Contributor

gakonst commented Jul 8, 2021

@vkgnosis @nlordell Any chance we can get a new release? I bumped on the bug which is fixed on this commit

@nlordell
Copy link
Contributor

nlordell commented Jul 8, 2021

Should have a release https://crates.io/crates/ethabi/14.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants