Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isn't Positions == FilterMapSpecialCase<Enumerate<Iter>, FilterMapSpecialCasePositions>? #892

Open
phimuemue opened this issue Mar 1, 2024 · 1 comment
Open

Isn't Positions == FilterMapSpecialCase<Enumerate<Iter>, FilterMapSpecialCasePositions>? #892

phimuemue opened this issue Mar 1, 2024 · 1 comment

Comments

@phimuemue
Copy link
Member

We have FilterMapOk and we have Positions.

I think we should make type FilterMapOk<Iter> = FilterMapSpecialCase<Iter, FilterMapSpecialCaseFnOk> and type Positions = FilterMapSpecialCase<Enumerate<Iter>, FilterMapSpecialCasePositions>.

Would enforce consitency for DoubleEndedIterator, fusedness, etc.
@Philippe-Cholet
Copy link
Member

Philippe-Cholet commented Mar 1, 2024 •
edited
Loading

Wow... that's bold, intriguing and definitely interesting.
I'm curious how it would impact benchmarks (for Positions mainly, since FilterMapOk might end up deprecated with #844).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phimuemue @Philippe-Cholet