Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test failure on 32-bit. #995

Open
plugwash opened this issue Oct 5, 2024 · 0 comments
Open

test failure on 32-bit. #995

plugwash opened this issue Oct 5, 2024 · 0 comments

Comments

@plugwash
Copy link

plugwash commented Oct 5, 2024

Debian CI revealed that the test combinations_inexact_size_hints fails on 32-bit architectures with an integer overflow

https://ci.debian.net/packages/r/rust-itertools/testing/i386/52667389/#S9

605s ---- combinations_inexact_size_hints stdout ----
605s thread 'combinations_inexact_size_hints' panicked at /usr/src/rustc-1.80.1/library/core/src/iter/traits/accum.rs:149:1:
605s attempt to multiply with overflow

I patched this in Debian by converting the values to u64 before doing the calculation and converting them back at the end.

https://salsa.debian.org/rust-team/debcargo-conf/-/blob/1e0bed11cc4ef40067840f9a9525eb94a0f146d9/src/itertools/debian/patches/fix-integer-overflow-in-test.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant