Skip to content

Commit 130e0dd

Browse files
committed
Auto merge of rust-lang#137766 - ChrisDenton:winsdk=10.0.22621.0, r=<try>
Downgrade 32-bit Windows SDK to 10.0.22621.0 in CI Reverts 6ea4823 and worksaround rust-lang#137733 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
2 parents f45d4ac + 914fb4d commit 130e0dd

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

.github/workflows/ci.yml

+14
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,20 @@ jobs:
7878
# Check the `calculate_matrix` job to see how is the matrix defined.
7979
include: ${{ fromJSON(needs.calculate_matrix.outputs.jobs) }}
8080
steps:
81+
# Temporary fix to unblock CI
82+
# We revert to an older Windows SDK for 32-bit Windows MSVC builds.
83+
# See issue https://github.com/rust-lang/rust/issues/137733 for more details.
84+
- name: Downgrade Windows SDK
85+
shell: pwsh
86+
if: ${{ matrix.name == 'i686-msvc-1' || matrix.name == 'i686-msvc-2' || matrix.name == 'dist-i686-msvc' }}
87+
run: |
88+
$vs = &"${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere.exe" -latest -format value -property installationPath
89+
&$vs\Common7\Tools\Launch-VsDevShell.ps1 -HostArch Amd64 -Arch x86
90+
Enter-VsDevshell -VsInstallPath $vs -HostArch Amd64 -Arch x86 -DevCmdArguments "-winsdk=10.0.22621.0"
91+
ls env: | foreach { echo "$($_.key)=$($_.value)" } >> $env:GITHUB_ENV
92+
$env:PATH += ";c:/msys64/usr/bin"
93+
$env:PATH >> $env:GITHUB_PATH
94+
8195
- name: disable git crlf conversion
8296
run: git config --global core.autocrlf false
8397

src/ci/github-actions/jobs.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -474,13 +474,13 @@ auto:
474474
env:
475475
RUST_CONFIGURE_ARGS: --build=i686-pc-windows-msvc --enable-sanitizers
476476
SCRIPT: make ci-msvc-py
477-
<<: *job-windows-8c
477+
<<: *job-windows
478478

479479
- name: i686-msvc-2
480480
env:
481481
RUST_CONFIGURE_ARGS: --build=i686-pc-windows-msvc --enable-sanitizers
482482
SCRIPT: make ci-msvc-ps1
483-
<<: *job-windows-8c
483+
<<: *job-windows
484484

485485
# x86_64-msvc-ext is split into multiple jobs to run tests in parallel.
486486
- name: x86_64-msvc-ext1
@@ -595,7 +595,7 @@ auto:
595595
SCRIPT: python x.py dist bootstrap --include-default-paths
596596
DIST_REQUIRE_ALL_TOOLS: 1
597597
CODEGEN_BACKENDS: llvm,cranelift
598-
<<: *job-windows-8c
598+
<<: *job-windows
599599

600600
- name: dist-aarch64-msvc
601601
env:

0 commit comments

Comments
 (0)