Rollup merge of rust-lang#122051 - erikdesjardins:cleanup, r=nikic

matthiaskrgr · web-flow · commit 1a85eb0187b0 · 2024-03-06T22:02:48.000+01:00
cleanup: remove zero-offset GEP This GEP would've been used to change the pointer type in the past, but after opaque pointers it's a no-op. I missed removing this in rust-lang#105545. Split out from rust-lang#121577.
diff --git a/compiler/rustc_codegen_ssa/src/mir/rvalue.rs b/compiler/rustc_codegen_ssa/src/mir/rvalue.rs
@@ -94,8 +94,7 @@ impl<'a, 'tcx, Bx: BuilderMethods<'a, 'tcx>> FunctionCx<'a, 'tcx, Bx> {
                 }
 
                 if let OperandValue::Immediate(v) = cg_elem.val {
-                    let zero = bx.const_usize(0);
-                    let start = dest.project_index(bx, zero).llval;
+                    let start = dest.llval;
                     let size = bx.const_usize(dest.layout.size.bytes());
 
                     // Use llvm.memset.p0i8.* to initialize all zero arrays

Original file line number	Diff line number	Diff line change
`@@ -94,8 +94,7 @@ impl<'a, 'tcx, Bx: BuilderMethods<'a, 'tcx>> FunctionCx<'a, 'tcx, Bx> {`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`if let OperandValue::Immediate(v) = cg_elem.val {`
`97`		`- let zero = bx.const_usize(0);`
`98`		`- let start = dest.project_index(bx, zero).llval;`
	`97`	`+ let start = dest.llval;`
`99`	`98`	`let size = bx.const_usize(dest.layout.size.bytes());`
`100`	`99`
`101`	`100`	`// Use llvm.memset.p0i8.* to initialize all zero arrays`