forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rollup merge of rust-lang#122370 - gurry:122199-ice-unexpected-node, r=davidtwco Gracefully handle `AnonConst` in `diagnostic_hir_wf_check()` Instead of running the WF check on the `AnonConst` itself we run it on the `ty` of the generic param of which the `AnonConst` is the default value. Fixes rust-lang#122199
- Loading branch information
Showing
3 changed files
with
82 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
trait Trait<const N: Trait = bar> { | ||
//~^ ERROR cannot find value `bar` in this scope | ||
//~| ERROR cycle detected when computing type of `Trait::N` | ||
//~| ERROR cycle detected when computing type of `Trait::N` | ||
//~| ERROR `(dyn Trait<{const error}> + 'static)` is forbidden as the type of a const generic parameter | ||
//~| WARN trait objects without an explicit `dyn` are deprecated | ||
//~| WARN this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! | ||
fn fnc(&self) { | ||
} | ||
} | ||
|
||
fn main() {} |
60 changes: 60 additions & 0 deletions
60
tests/ui/wf/ice-hir-wf-check-anon-const-issue-122199.stderr
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
error[E0425]: cannot find value `bar` in this scope | ||
--> $DIR/ice-hir-wf-check-anon-const-issue-122199.rs:1:30 | ||
| | ||
LL | trait Trait<const N: Trait = bar> { | ||
| ^^^ not found in this scope | ||
|
||
warning: trait objects without an explicit `dyn` are deprecated | ||
--> $DIR/ice-hir-wf-check-anon-const-issue-122199.rs:1:22 | ||
| | ||
LL | trait Trait<const N: Trait = bar> { | ||
| ^^^^^ | ||
| | ||
= warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! | ||
= note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/warnings-promoted-to-error.html> | ||
= note: `#[warn(bare_trait_objects)]` on by default | ||
help: if this is an object-safe trait, use `dyn` | ||
| | ||
LL | trait Trait<const N: dyn Trait = bar> { | ||
| +++ | ||
|
||
error[E0391]: cycle detected when computing type of `Trait::N` | ||
--> $DIR/ice-hir-wf-check-anon-const-issue-122199.rs:1:22 | ||
| | ||
LL | trait Trait<const N: Trait = bar> { | ||
| ^^^^^ | ||
| | ||
= note: ...which immediately requires computing type of `Trait::N` again | ||
note: cycle used when computing explicit predicates of trait `Trait` | ||
--> $DIR/ice-hir-wf-check-anon-const-issue-122199.rs:1:1 | ||
| | ||
LL | trait Trait<const N: Trait = bar> { | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
= note: see https://rustc-dev-guide.rust-lang.org/overview.html#queries and https://rustc-dev-guide.rust-lang.org/query.html for more information | ||
|
||
error[E0391]: cycle detected when computing type of `Trait::N` | ||
--> $DIR/ice-hir-wf-check-anon-const-issue-122199.rs:1:13 | ||
| | ||
LL | trait Trait<const N: Trait = bar> { | ||
| ^^^^^^^^^^^^^^^^^^^^ | ||
| | ||
= note: ...which immediately requires computing type of `Trait::N` again | ||
note: cycle used when computing explicit predicates of trait `Trait` | ||
--> $DIR/ice-hir-wf-check-anon-const-issue-122199.rs:1:1 | ||
| | ||
LL | trait Trait<const N: Trait = bar> { | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
= note: see https://rustc-dev-guide.rust-lang.org/overview.html#queries and https://rustc-dev-guide.rust-lang.org/query.html for more information | ||
|
||
error: `(dyn Trait<{const error}> + 'static)` is forbidden as the type of a const generic parameter | ||
--> $DIR/ice-hir-wf-check-anon-const-issue-122199.rs:1:22 | ||
| | ||
LL | trait Trait<const N: Trait = bar> { | ||
| ^^^^^ | ||
| | ||
= note: the only supported types are integers, `bool` and `char` | ||
|
||
error: aborting due to 4 previous errors; 1 warning emitted | ||
|
||
Some errors have detailed explanations: E0391, E0425. | ||
For more information about an error, try `rustc --explain E0391`. |