Skip to content

Commit 35785ef

Browse files
committed
tests: re-enable dump-ice-to-disk for Windows
This test was previously flakey on `i686-mingw`, but since some modifications I could no longer make it fail on `i686-mingw`. See <rust-lang#128958> for multiple try job runs.
1 parent 13a5289 commit 35785ef

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

tests/run-make/dump-ice-to-disk/rmake.rs

+8-5
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,14 @@
1414
//! that `RUSTC_ICE_PATH` takes precedence and no ICE dump is emitted under `METRICS_PATH`.
1515
//!
1616
//! See <https://github.com/rust-lang/rust/pull/108714>.
17-
18-
//@ ignore-windows
19-
// FIXME(#128911): @jieyouxu: This test is sometimes for whatever forsaken reason flakey in
20-
// `i686-mingw`, and I cannot reproduce it locally. The error messages upon assertion failure in
21-
// this test is intentionally extremely verbose to aid debugging that issue.
17+
//!
18+
//! # Test history
19+
//!
20+
//! - The previous rmake.rs iteration of this test was flakey for unknown reason on `i686-mingw`
21+
//! *specifically*, so assertion failures in this test was made extremely verbose to help
22+
//! diagnose why the ICE messages was different *specifically* on `i686-mingw`.
23+
//! - An attempt is made to re-enable this test on `i686-mingw` (by removing `ignore-windows`). If
24+
//! this test is still flakey, please restore the `ignore-windows` directive.
2225
2326
use std::cell::OnceCell;
2427
use std::path::{Path, PathBuf};

0 commit comments

Comments
 (0)