forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't recover lifetimes/labels containing emojis as character literals
Note that at the time of this commit, `unic-emoji-char` seems to have data tables only up to Unicode 5.0, but Unicode is already newer than this. A newer emoji such as `🥺` will not be recognized as an emoji but older emojis such as `🐱` will.
- Loading branch information
Showing
5 changed files
with
173 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
#![allow(unused_labels)] | ||
|
||
// FIXME(#108019): outdated Unicode table | ||
// fn foo() { | ||
// '🥺 loop { | ||
// break | ||
// } | ||
// } | ||
|
||
fn bar() { | ||
'🐱 loop { | ||
//~^ ERROR labeled expression must be followed by `:` | ||
//~| ERROR lifetimes or labels cannot contain emojis | ||
break | ||
} | ||
} | ||
|
||
fn qux() { | ||
'a🐱 loop { | ||
//~^ ERROR labeled expression must be followed by `:` | ||
//~| ERROR lifetimes or labels cannot contain emojis | ||
break | ||
} | ||
} | ||
|
||
fn quux() { | ||
'1🐱 loop { | ||
//~^ ERROR labeled expression must be followed by `:` | ||
//~| ERROR lifetimes or labels cannot start with a number | ||
break | ||
} | ||
} | ||
|
||
fn x<'🐱>() -> &'🐱 () { | ||
//~^ ERROR lifetimes or labels cannot contain emojis | ||
//~| ERROR lifetimes or labels cannot contain emojis | ||
&() | ||
} | ||
|
||
fn y() { | ||
'a🐱: loop {} | ||
//~^ ERROR lifetimes or labels cannot contain emojis | ||
} | ||
|
||
fn main() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
error: labeled expression must be followed by `:` | ||
--> $DIR/issue-108019-bad-emoji-recovery.rs:11:5 | ||
| | ||
LL | '🐱 loop { | ||
| ^--- help: add `:` after the label | ||
| | | ||
| _____the label | ||
| | | ||
LL | | | ||
LL | | | ||
LL | | break | ||
LL | | } | ||
| |_____^ | ||
| | ||
= note: labels are used before loops and blocks, allowing e.g., `break 'label` to them | ||
|
||
error: labeled expression must be followed by `:` | ||
--> $DIR/issue-108019-bad-emoji-recovery.rs:19:5 | ||
| | ||
LL | 'a🐱 loop { | ||
| ^---- help: add `:` after the label | ||
| | | ||
| _____the label | ||
| | | ||
LL | | | ||
LL | | | ||
LL | | break | ||
LL | | } | ||
| |_____^ | ||
| | ||
= note: labels are used before loops and blocks, allowing e.g., `break 'label` to them | ||
|
||
error: labeled expression must be followed by `:` | ||
--> $DIR/issue-108019-bad-emoji-recovery.rs:27:5 | ||
| | ||
LL | '1🐱 loop { | ||
| ^---- help: add `:` after the label | ||
| | | ||
| _____the label | ||
| | | ||
LL | | | ||
LL | | | ||
LL | | break | ||
LL | | } | ||
| |_____^ | ||
| | ||
= note: labels are used before loops and blocks, allowing e.g., `break 'label` to them | ||
|
||
error: lifetimes or labels cannot contain emojis | ||
--> $DIR/issue-108019-bad-emoji-recovery.rs:11:5 | ||
| | ||
LL | '🐱 loop { | ||
| ^^^ | ||
|
||
error: lifetimes or labels cannot contain emojis | ||
--> $DIR/issue-108019-bad-emoji-recovery.rs:19:5 | ||
| | ||
LL | 'a🐱 loop { | ||
| ^^^^ | ||
|
||
error: lifetimes or labels cannot start with a number | ||
--> $DIR/issue-108019-bad-emoji-recovery.rs:27:5 | ||
| | ||
LL | '1🐱 loop { | ||
| ^^^^ | ||
|
||
error: lifetimes or labels cannot contain emojis | ||
--> $DIR/issue-108019-bad-emoji-recovery.rs:34:6 | ||
| | ||
LL | fn x<'🐱>() -> &'🐱 () { | ||
| ^^^ | ||
|
||
error: lifetimes or labels cannot contain emojis | ||
--> $DIR/issue-108019-bad-emoji-recovery.rs:34:16 | ||
| | ||
LL | fn x<'🐱>() -> &'🐱 () { | ||
| ^^^ | ||
|
||
error: lifetimes or labels cannot contain emojis | ||
--> $DIR/issue-108019-bad-emoji-recovery.rs:41:5 | ||
| | ||
LL | 'a🐱: loop {} | ||
| ^^^^ | ||
|
||
error: aborting due to 9 previous errors | ||
|