Skip to content

Commit 39875bd

Browse files
authored
Unrolled build for rust-lang#121039
Rollup merge of rust-lang#121039 - cjgillot:gvn-adjust, r=compiler-errors Correctly compute adjustment casts in GVN Fixes rust-lang#120925 r? `@oli-obk`
2 parents 81b757c + a97e4af commit 39875bd

File tree

2 files changed

+34
-5
lines changed

2 files changed

+34
-5
lines changed

compiler/rustc_mir_transform/src/gvn.rs

+9-5
Original file line numberDiff line numberDiff line change
@@ -561,18 +561,22 @@ impl<'body, 'tcx> VnState<'body, 'tcx> {
561561
.ok()?;
562562
dest.into()
563563
}
564-
CastKind::FnPtrToPtr
565-
| CastKind::PtrToPtr
566-
| CastKind::PointerCoercion(
564+
CastKind::FnPtrToPtr | CastKind::PtrToPtr => {
565+
let src = self.evaluated[value].as_ref()?;
566+
let src = self.ecx.read_immediate(src).ok()?;
567+
let to = self.ecx.layout_of(to).ok()?;
568+
let ret = self.ecx.ptr_to_ptr(&src, to).ok()?;
569+
ret.into()
570+
}
571+
CastKind::PointerCoercion(
567572
ty::adjustment::PointerCoercion::MutToConstPointer
568573
| ty::adjustment::PointerCoercion::ArrayToPointer
569574
| ty::adjustment::PointerCoercion::UnsafeFnPointer,
570575
) => {
571576
let src = self.evaluated[value].as_ref()?;
572577
let src = self.ecx.read_immediate(src).ok()?;
573578
let to = self.ecx.layout_of(to).ok()?;
574-
let ret = self.ecx.ptr_to_ptr(&src, to).ok()?;
575-
ret.into()
579+
ImmTy::from_immediate(*src, to).into()
576580
}
577581
_ => return None,
578582
},
+25
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
// Verify that we do not ICE when attempting to interpret casts between fn types.
2+
// skip-filecheck
3+
4+
static FOO: fn() = || assert_ne!(42, 43);
5+
static BAR: fn(i32, i32) = |a, b| assert_ne!(a, b);
6+
7+
fn main() {
8+
FOO();
9+
10+
let bar: unsafe fn(i32, i32) = BAR;
11+
12+
let f: fn() = || {};
13+
f();
14+
15+
f();
16+
17+
f();
18+
19+
let g: fn(i32) = |i| assert_eq!(i, 2);
20+
g(2);
21+
22+
g(2);
23+
24+
g(2);
25+
}

0 commit comments

Comments
 (0)