Skip to content

Commit 3b370cf

Browse files
committed
Auto merge of rust-lang#123098 - matthiaskrgr:rollup-39v4rf3, r=matthiaskrgr
Rollup of 10 pull requests Successful merges: - rust-lang#122766 (store segment and module in `UnresolvedImportError`) - rust-lang#122996 (simplify_branches: add comment) - rust-lang#123047 (triagebot: Add notification of 2024 issues) - rust-lang#123066 (CFI: (actually) check that methods are object-safe before projecting their receivers to `dyn Trait` in CFI) - rust-lang#123067 (match lowering: consistently merge simple or-patterns) - rust-lang#123069 (Revert `cargo update` changes and bump `download-artifact` to v4) - rust-lang#123070 (Add my former address to .mailmap) - rust-lang#123086 (Fix doc link to BufWriter in std::fs::File documentation) - rust-lang#123090 (Remove `CacheSelector` trait now that we can use GATs) - rust-lang#123091 (Delegation: fix ICE on wrong `self` resolution) r? `@ghost` `@rustbot` modify labels: rollup
2 parents 536606b + 4d1fb9e commit 3b370cf

File tree

22 files changed

+393
-184
lines changed

22 files changed

+393
-184
lines changed

.github/workflows/dependencies.yml

+7-12
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ on:
66
schedule:
77
# Run weekly
88
- cron: '0 0 * * Sun'
9-
# Re-bump deps every 4 hours
10-
- cron: '0 */4 * * *'
119
workflow_dispatch:
1210
# Needed so we can run it manually
1311
permissions:
@@ -42,7 +40,7 @@ jobs:
4240
4341
# Exit with error if open and S-waiting-on-bors
4442
if [[ "$STATE" == "OPEN" && "$WAITING_ON_BORS" == "true" ]]; then
45-
gh run cancel ${{ github.run_id }}
43+
exit 1
4644
fi
4745
4846
update:
@@ -65,10 +63,7 @@ jobs:
6563
6664
- name: cargo update
6765
# Remove first line that always just says "Updating crates.io index"
68-
# If there are no changes, cancel the job here
69-
run: |
70-
cargo update 2>&1 | sed '/crates.io index/d' | tee -a cargo_update.log
71-
git status --porcelain | grep -q Cargo.lock || gh run cancel ${{ github.run_id }}
66+
run: cargo update 2>&1 | sed '/crates.io index/d' | tee -a cargo_update.log
7267
- name: upload Cargo.lock artifact for use in PR
7368
uses: actions/upload-artifact@v4
7469
with:
@@ -95,11 +90,11 @@ jobs:
9590
uses: actions/checkout@v4
9691

9792
- name: download Cargo.lock from update job
98-
uses: actions/download-artifact@v3
93+
uses: actions/download-artifact@v4
9994
with:
10095
name: Cargo-lock
10196
- name: download cargo-update log from update job
102-
uses: actions/download-artifact@v3
97+
uses: actions/download-artifact@v4
10398
with:
10499
name: cargo-updates
105100

@@ -134,14 +129,14 @@ jobs:
134129
# Exit with error if PR is closed
135130
STATE=$(gh pr view cargo_update --repo $GITHUB_REPOSITORY --json state --jq '.state')
136131
if [[ "$STATE" != "OPEN" ]]; then
137-
gh run cancel ${{ github.run_id }}
132+
exit 1
138133
fi
139134
140135
gh pr edit cargo_update --title "${PR_TITLE}" --body-file body.md --repo $GITHUB_REPOSITORY
141136
142137
- name: open new pull request
143-
# Only run if there wasn't an existing PR and if this is the weekly run
144-
if: steps.edit.outcome != 'success' && github.event.schedule == '0 0 * * Sun'
138+
# Only run if there wasn't an existing PR
139+
if: steps.edit.outcome != 'success'
145140
env:
146141
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
147142
run: gh pr create --title "${PR_TITLE}" --body-file body.md --repo $GITHUB_REPOSITORY

.mailmap

+1
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,7 @@ Katze <binary@benary.org>
324324
Keegan McAllister <mcallister.keegan@gmail.com> <kmcallister@mozilla.com>
325325
Kerem Kat <keremkat@gmail.com>
326326
Kevin Butler <haqkrs@gmail.com>
327+
Kevin Reid <kpreid@switchb.org> <kpreid@google.com>
327328
Kevin Jiang <kwj2104@columbia.edu>
328329
Kornel Lesiński <kornel@geekhood.net>
329330
Krishna Sai Veera Reddy <veerareddy@email.arizona.edu>

0 commit comments

Comments
 (0)