Skip to content

Commit 54bdfa1

Browse files
committed
Auto merge of rust-lang#85252 - kulikjak:fix-solaris-CI, r=Mark-Simulacrum
Bring back `x86_64-sun-solaris` target to rustup Change rust-lang#82216 removed now deprecated target `x86_64-sun-solaris` from CI, thus making it no longer possible to use `$ rustup target add x86_64-sun-solaris` to install given target (see rust-lang#85098 for details). Since there should be a period of time between the deprecation and removal, this PR brings it back (while keeping the new one as well). Please, correct me if I am wrong; my assumption that these Docker scripts are being used to build artifacts later used by `rustup` might be incorrect. Closes rust-lang#85098.
2 parents 47a90f4 + b13185d commit 54bdfa1

File tree

2 files changed

+10
-14
lines changed

2 files changed

+10
-14
lines changed

src/ci/docker/host-x86_64/dist-various-2/Dockerfile

+8-2
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,9 @@ ENV \
4242
AR_x86_64_pc_solaris=x86_64-pc-solaris2.10-ar \
4343
CC_x86_64_pc_solaris=x86_64-pc-solaris2.10-gcc \
4444
CXX_x86_64_pc_solaris=x86_64-pc-solaris2.10-g++ \
45+
AR_x86_64_sun_solaris=x86_64-sun-solaris2.10-ar \
46+
CC_x86_64_sun_solaris=x86_64-sun-solaris2.10-gcc \
47+
CXX_x86_64_sun_solaris=x86_64-sun-solaris2.10-g++ \
4548
CC_armv7_unknown_linux_gnueabi=arm-linux-gnueabi-gcc-8 \
4649
CXX_armv7_unknown_linux_gnueabi=arm-linux-gnueabi-g++-8 \
4750
AR_x86_64_fortanix_unknown_sgx=ar \
@@ -68,8 +71,10 @@ COPY host-x86_64/dist-various-2/shared.sh /tmp/
6871
COPY host-x86_64/dist-various-2/build-fuchsia-toolchain.sh /tmp/
6972
RUN /tmp/build-fuchsia-toolchain.sh
7073
COPY host-x86_64/dist-various-2/build-solaris-toolchain.sh /tmp/
71-
RUN /tmp/build-solaris-toolchain.sh x86_64 amd64 solaris-i386
72-
RUN /tmp/build-solaris-toolchain.sh sparcv9 sparcv9 solaris-sparc
74+
RUN /tmp/build-solaris-toolchain.sh x86_64 amd64 solaris-i386 pc
75+
# Build deprecated target 'x86_64-sun-solaris2.10' until removed
76+
RUN /tmp/build-solaris-toolchain.sh x86_64 amd64 solaris-i386 sun
77+
RUN /tmp/build-solaris-toolchain.sh sparcv9 sparcv9 solaris-sparc sun
7378
COPY host-x86_64/dist-various-2/build-x86_64-fortanix-unknown-sgx-toolchain.sh /tmp/
7479
RUN /tmp/build-x86_64-fortanix-unknown-sgx-toolchain.sh
7580

@@ -99,6 +104,7 @@ ENV TARGETS=$TARGETS,wasm32-unknown-unknown
99104
ENV TARGETS=$TARGETS,wasm32-wasi
100105
ENV TARGETS=$TARGETS,sparcv9-sun-solaris
101106
ENV TARGETS=$TARGETS,x86_64-pc-solaris
107+
ENV TARGETS=$TARGETS,x86_64-sun-solaris
102108
ENV TARGETS=$TARGETS,x86_64-unknown-linux-gnux32
103109
ENV TARGETS=$TARGETS,x86_64-fortanix-unknown-sgx
104110
ENV TARGETS=$TARGETS,nvptx64-nvidia-cuda

src/ci/docker/host-x86_64/dist-various-2/build-solaris-toolchain.sh

+2-12
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,11 @@ source shared.sh
66
ARCH=$1
77
LIB_ARCH=$2
88
APT_ARCH=$3
9+
MANUFACTURER=$4
910
BINUTILS=2.28.1
1011
GCC=6.5.0
1112

12-
# Choose correct target based on the $ARCH
13-
case "$ARCH" in
14-
x86_64)
15-
TARGET=x86_64-pc-solaris2.10
16-
;;
17-
sparcv9)
18-
TARGET=sparcv9-sun-solaris2.10
19-
;;
20-
*)
21-
printf 'ERROR: unknown architecture: %s\n' "$ARCH"
22-
exit 1
23-
esac
13+
TARGET=${ARCH}-${MANUFACTURER}-solaris2.10
2414

2515
# First up, build binutils
2616
mkdir binutils

0 commit comments

Comments
 (0)