Skip to content

Commit 6b66035

Browse files
committed
Auto merge of rust-lang#120358 - tmandry:bump-fuchsia-8c-tests, r=<try>
Bump Fuchsia, build tests, and use 8 core bots - Build Fuchsia on 8 cores instead of 16 - Skip building cranelift for Fuchsia - Bump Fuchsia (includes building tests) This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder. See prior discussion on rust-lang#119400 about building on 8 cores instead of 16. This PR combines changes from that and rust-lang#119399, plus clean up. r? `@Mark-Simulacrum`
2 parents 0c1fb2a + 3ff836e commit 6b66035

File tree

5 files changed

+21
-15
lines changed

5 files changed

+21
-15
lines changed

.github/workflows/ci.yml

+4-5
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ jobs:
291291
- name: x86_64-gnu-integration
292292
env:
293293
CI_ONLY_WHEN_CHANNEL: nightly
294-
os: ubuntu-20.04-16core-64gb
294+
os: ubuntu-20.04-8core-32gb
295295
- name: x86_64-gnu-debug
296296
os: ubuntu-20.04-8core-32gb
297297
env: {}
@@ -567,10 +567,9 @@ jobs:
567567
strategy:
568568
matrix:
569569
include:
570-
- name: dist-x86_64-linux
571-
env:
572-
CODEGEN_BACKENDS: "llvm,cranelift"
573-
os: ubuntu-20.04-16core-64gb
570+
- name: x86_64-gnu-integration
571+
os: ubuntu-20.04-8core-32gb
572+
env: {}
574573
timeout-minutes: 600
575574
runs-on: "${{ matrix.os }}"
576575
steps:

src/ci/docker/host-x86_64/x86_64-gnu-integration/Dockerfile

+3
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@ RUN sh /scripts/sccache.sh
5151
ENV RUST_INSTALL_DIR /checkout/obj/install
5252
RUN mkdir -p $RUST_INSTALL_DIR/etc
5353

54+
# Fuchsia only supports LLVM.
55+
ENV CODEGEN_BACKENDS llvm
56+
5457
ENV RUST_CONFIGURE_ARGS \
5558
--prefix=$RUST_INSTALL_DIR \
5659
--sysconfdir=etc \

src/ci/docker/host-x86_64/x86_64-gnu-integration/build-fuchsia.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
set -euf -o pipefail
77

8-
INTEGRATION_SHA=66793c4894bf6204579bbee3b79956335f31c768
8+
INTEGRATION_SHA=56310bca298872ffb5ea02e665956d9b6dc41171
99
PICK_REFS=()
1010

1111
checkout=fuchsia

src/ci/github-actions/ci.yml

+8-6
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@ jobs:
476476
# nightly features to compile, and this job would fail if
477477
# executed on beta and stable.
478478
CI_ONLY_WHEN_CHANNEL: nightly
479-
<<: *job-linux-16c
479+
<<: *job-linux-8c
480480

481481
- name: x86_64-gnu-debug
482482
<<: *job-linux-8c
@@ -724,11 +724,13 @@ jobs:
724724
strategy:
725725
matrix:
726726
include:
727-
- &dist-x86_64-linux
728-
name: dist-x86_64-linux
729-
env:
730-
CODEGEN_BACKENDS: llvm,cranelift
731-
<<: *job-linux-16c
727+
- name: x86_64-gnu-integration
728+
<<: *job-linux-8c
729+
#- &dist-x86_64-linux
730+
# name: dist-x86_64-linux
731+
# env:
732+
# CODEGEN_BACKENDS: llvm,cranelift
733+
# <<: *job-linux-16c
732734

733735

734736
master:

src/ci/run.sh

+5-3
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,8 @@ if [ "$DEPLOY$DEPLOY_ALT" = "1" ]; then
119119
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.verify-llvm-ir"
120120
fi
121121

122-
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.codegen-backends=${CODEGEN_BACKENDS:-llvm}"
122+
CODEGEN_BACKENDS="${CODEGEN_BACKENDS:-llvm}"
123+
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.codegen-backends=$CODEGEN_BACKENDS"
123124
else
124125
# We almost always want debug assertions enabled, but sometimes this takes too
125126
# long for too little benefit, so we just turn them off.
@@ -144,11 +145,12 @@ else
144145
# tests as it will fail them.
145146
if [[ "${ENABLE_GCC_CODEGEN}" == "1" ]]; then
146147
# Test the Cranelift and GCC backends in CI. Bootstrap knows which targets to run tests on.
147-
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.codegen-backends=llvm,cranelift,gcc"
148+
CODEGEN_BACKENDS="${CODEGEN_BACKENDS:-llvm,cranelift,gcc}"
148149
else
149150
# Test the Cranelift backend in CI. Bootstrap knows which targets to run tests on.
150-
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.codegen-backends=llvm,cranelift"
151+
CODEGEN_BACKENDS="${CODEGEN_BACKENDS:-llvm,cranelift}"
151152
fi
153+
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.codegen-backends=$CODEGEN_BACKENDS"
152154

153155
# We enable this for non-dist builders, since those aren't trying to produce
154156
# fresh binaries. We currently don't entirely support distributing a fresh

0 commit comments

Comments
 (0)