forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rollup merge of rust-lang#122160 - jieyouxu:eager-translate-help-use-latest-edition, r=cjgillot Eagerly translate `HelpUseLatestEdition` in parser diagnostics Fixes rust-lang#122130. This makes me suspicious of these other two usage of `add_to_diagnostic()`. Would they *also* crash? I haven't attempted to construct test cases for them. ``` compiler/rustc_parse/src/parser/expr.rs 3453: errors::HelpUseLatestEdition::new().add_to_diagnostic(e); compiler/rustc_hir_typeck/src/expr.rs 2603: HelpUseLatestEdition::new().add_to_diagnostic(&mut err); ``` This also seems like a footgun?
- Loading branch information
Showing
3 changed files
with
27 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
enum will { | ||
s#[c"owned_box"] | ||
//~^ERROR expected one of `(`, `,`, `=`, `{`, or `}`, found `#` | ||
//~|ERROR expected item, found `"owned_box"` | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
error: expected one of `(`, `,`, `=`, `{`, or `}`, found `#` | ||
--> $DIR/help-set-edition-ice-122130.rs:2:6 | ||
| | ||
LL | s#[c"owned_box"] | ||
| ^ expected one of `(`, `,`, `=`, `{`, or `}` | ||
| | ||
= note: you may be trying to write a c-string literal | ||
= note: c-string literals require Rust 2021 or later | ||
= help: pass `--edition 2021` to `rustc` | ||
= note: for more on editions, read https://doc.rust-lang.org/edition-guide | ||
|
||
error: expected item, found `"owned_box"` | ||
--> $DIR/help-set-edition-ice-122130.rs:2:9 | ||
| | ||
LL | s#[c"owned_box"] | ||
| ^^^^^^^^^^^ expected item | ||
| | ||
= note: for a full list of items that can appear in modules, see <https://doc.rust-lang.org/reference/items.html> | ||
|
||
error: aborting due to 2 previous errors | ||
|