Skip to content

Commit b959328

Browse files
committed
Auto merge of rust-lang#87369 - pnkfelix:beta-targetted-revert-81473-warn-write-only-fields, r=Mark-Simulacrum
Beta targetted revert 81473 warn write only fields beta backport of PR rust-lang#86212
2 parents ff4ca50 + e541354 commit b959328

File tree

4 files changed

+1
-119
lines changed

4 files changed

+1
-119
lines changed

compiler/rustc_passes/src/dead.rs

+1-5
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ impl<'tcx> MarkSymbolVisitor<'tcx> {
134134
}
135135
}
136136

137+
#[allow(dead_code)] // FIXME(81658): should be used + lint reinstated after #83171 relands.
137138
fn handle_assign(&mut self, expr: &'tcx hir::Expr<'tcx>) {
138139
if self
139140
.typeck_results()
@@ -285,11 +286,6 @@ impl<'tcx> Visitor<'tcx> for MarkSymbolVisitor<'tcx> {
285286
hir::ExprKind::MethodCall(..) => {
286287
self.lookup_and_handle_method(expr.hir_id);
287288
}
288-
hir::ExprKind::Assign(ref left, ref right, ..) => {
289-
self.handle_assign(left);
290-
self.visit_expr(right);
291-
return;
292-
}
293289
hir::ExprKind::Field(ref lhs, ..) => {
294290
self.handle_field_access(&lhs, expr.hir_id);
295291
}

src/test/ui/borrowck/borrowck-assign-to-subfield.rs

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
// run-pass
22
// pretty-expanded FIXME #23616
3-
#![allow(dead_code)]
43

54
pub fn main() {
65
struct A {

src/test/ui/lint/dead-code/write-only-field.rs

-69
This file was deleted.

src/test/ui/lint/dead-code/write-only-field.stderr

-44
This file was deleted.

0 commit comments

Comments
 (0)