forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rollup merge of rust-lang#120597 - fmease:sugg-on-js-style-spread-op-in-pat, r=estebank Suggest `[tail @ ..]` on `[..tail]` and `[...tail]` where `tail` is unresolved Fixes rust-lang#120591. ~~Will conflict with rust-lang#120570~~ (rebased). r? estebank or compiler
- Loading branch information
Showing
5 changed files
with
112 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 15 additions & 1 deletion
16
tests/ui/pattern/range-pattern-meant-to-be-slice-rest-pattern.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,23 @@ | ||
fn main() { | ||
match &[1, 2, 3][..] { | ||
[1, rest..] => println!("{rest:?}"), | ||
[1, rest..] => println!("{rest}"), | ||
//~^ ERROR cannot find value `rest` in this scope | ||
//~| ERROR cannot find value `rest` in this scope | ||
//~| ERROR `X..` patterns in slices are experimental | ||
_ => {} | ||
} | ||
match &[4, 5, 6][..] { | ||
[] => {} | ||
[_, ..tail] => println!("{tail}"), | ||
//~^ ERROR cannot find value `tail` in this scope | ||
//~| ERROR cannot find value `tail` in this scope | ||
//~| ERROR exclusive range pattern syntax is experimental | ||
} | ||
match &[7, 8, 9][..] { | ||
[] => {} | ||
[_, ...tail] => println!("{tail}"), | ||
//~^ ERROR cannot find value `tail` in this scope | ||
//~| ERROR cannot find value `tail` in this scope | ||
//~| ERROR range-to patterns with `...` are not allowed | ||
} | ||
} |
61 changes: 56 additions & 5 deletions
61
tests/ui/pattern/range-pattern-meant-to-be-slice-rest-pattern.stderr
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,31 +1,82 @@ | ||
error: range-to patterns with `...` are not allowed | ||
--> $DIR/range-pattern-meant-to-be-slice-rest-pattern.rs:18:13 | ||
| | ||
LL | [_, ...tail] => println!("{tail}"), | ||
| ^^^ help: use `..=` instead | ||
|
||
error[E0425]: cannot find value `rest` in this scope | ||
--> $DIR/range-pattern-meant-to-be-slice-rest-pattern.rs:3:13 | ||
| | ||
LL | [1, rest..] => println!("{rest:?}"), | ||
LL | [1, rest..] => println!("{rest}"), | ||
| ^^^^ not found in this scope | ||
| | ||
help: if you meant to collect the rest of the slice in `rest`, use the at operator | ||
| | ||
LL | [1, rest @ ..] => println!("{rest:?}"), | ||
LL | [1, rest @ ..] => println!("{rest}"), | ||
| + | ||
|
||
error[E0425]: cannot find value `rest` in this scope | ||
--> $DIR/range-pattern-meant-to-be-slice-rest-pattern.rs:3:35 | ||
| | ||
LL | [1, rest..] => println!("{rest:?}"), | ||
LL | [1, rest..] => println!("{rest}"), | ||
| ^^^^ not found in this scope | ||
|
||
error[E0425]: cannot find value `tail` in this scope | ||
--> $DIR/range-pattern-meant-to-be-slice-rest-pattern.rs:11:15 | ||
| | ||
LL | [_, ..tail] => println!("{tail}"), | ||
| ^^^^ not found in this scope | ||
| | ||
help: if you meant to collect the rest of the slice in `tail`, use the at operator | ||
| | ||
LL | [_, tail @ ..] => println!("{tail}"), | ||
| ~~~~~~~~~ | ||
|
||
error[E0425]: cannot find value `tail` in this scope | ||
--> $DIR/range-pattern-meant-to-be-slice-rest-pattern.rs:11:35 | ||
| | ||
LL | [_, ..tail] => println!("{tail}"), | ||
| ^^^^ not found in this scope | ||
|
||
error[E0425]: cannot find value `tail` in this scope | ||
--> $DIR/range-pattern-meant-to-be-slice-rest-pattern.rs:18:16 | ||
| | ||
LL | [_, ...tail] => println!("{tail}"), | ||
| ^^^^ not found in this scope | ||
| | ||
help: if you meant to collect the rest of the slice in `tail`, use the at operator | ||
| | ||
LL | [_, tail @ ..] => println!("{tail}"), | ||
| ~~~~~~~~~ | ||
|
||
error[E0425]: cannot find value `tail` in this scope | ||
--> $DIR/range-pattern-meant-to-be-slice-rest-pattern.rs:18:36 | ||
| | ||
LL | [_, ...tail] => println!("{tail}"), | ||
| ^^^^ not found in this scope | ||
|
||
error[E0658]: `X..` patterns in slices are experimental | ||
--> $DIR/range-pattern-meant-to-be-slice-rest-pattern.rs:3:13 | ||
| | ||
LL | [1, rest..] => println!("{rest:?}"), | ||
LL | [1, rest..] => println!("{rest}"), | ||
| ^^^^^^ | ||
| | ||
= note: see issue #67264 <https://github.com/rust-lang/rust/issues/67264> for more information | ||
= help: add `#![feature(half_open_range_patterns_in_slices)]` to the crate attributes to enable | ||
= note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date | ||
|
||
error: aborting due to 3 previous errors | ||
error[E0658]: exclusive range pattern syntax is experimental | ||
--> $DIR/range-pattern-meant-to-be-slice-rest-pattern.rs:11:13 | ||
| | ||
LL | [_, ..tail] => println!("{tail}"), | ||
| ^^^^^^ | ||
| | ||
= note: see issue #37854 <https://github.com/rust-lang/rust/issues/37854> for more information | ||
= help: add `#![feature(exclusive_range_pattern)]` to the crate attributes to enable | ||
= note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date | ||
= help: use an inclusive range pattern, like N..=M | ||
|
||
error: aborting due to 9 previous errors | ||
|
||
Some errors have detailed explanations: E0425, E0658. | ||
For more information about an error, try `rustc --explain E0425`. |