Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

Add (temporary) MIR builders. #82

Closed
eddyb opened this issue Mar 19, 2016 · 4 comments
Closed

Add (temporary) MIR builders. #82

eddyb opened this issue Mar 19, 2016 · 4 comments

Comments

@eddyb
Copy link
Contributor

eddyb commented Mar 19, 2016

Until MIR is turned on by default for everyone, we want to make sure we don't regress.

In rust-lang/rust#32080 I've tagged relevant functions in tests that involve features not yet in MIR (such as debuginfo or overflow checks) with #[rustc_no_mir], and we can keep adding those as long as we track them, so I believe the new MIR builders should gate all builds.

We're going to need at least one UNIX builder and one MSVC because of the unwinding complexities found in the latter (I don't even know if MSVC can bootstrap w/ MIR right now).

Blocked on the snapshots being added in rust-lang/rust#32345. cc @alexcrichton

@alexcrichton
Copy link
Contributor

This is just enabled with ./configure --enable-orbit, right?

@alexcrichton
Copy link
Contributor

And then we just run make check?

@eddyb
Copy link
Contributor Author

eddyb commented Mar 19, 2016

@alexcrichton Correct, I did this on a x64 linux machine and it completed successfully.

@alexcrichton
Copy link
Contributor

Ok, done in 4d3bc18, will deploy shortly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants