Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Clone and Debug for internal_scc::SccGraph and Debug for _Edge #147

Closed
NotLeonian opened this issue Feb 25, 2025 · 0 comments · Fixed by #157
Closed

Implement Clone and Debug for internal_scc::SccGraph and Debug for _Edge #147

NotLeonian opened this issue Feb 25, 2025 · 0 comments · Fixed by #157

Comments

@NotLeonian
Copy link
Contributor

To implement Clone and Debug for SccGraph and TwoSat, internal_scc::SccGraph must also support Clone and Debug.
Additionally, implementing Debug for internal_scc::SccGraph requires implementing Debug for _Edge.

The Clone trait for internal_scc::SccGraph can be derived.
For the Debug trait, discussion is needed regarding the output format.
I think that the Debug trait for _Edge can simply be derived.
Similarly, I think deriving Debug for internal_scc::SccGraph is also sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant