Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Clone and Debug for MfGraph and _Edge #150

Open
NotLeonian opened this issue Feb 26, 2025 · 1 comment · May be fixed by #159
Open

Implement Clone and Debug for MfGraph and _Edge #150

NotLeonian opened this issue Feb 26, 2025 · 1 comment · May be fixed by #159

Comments

@NotLeonian
Copy link
Contributor

Implement the Clone and Debug traits for MfGraph.
This requires implementing Clone and Debug for _Edge as well.

To implement this change, we first need to choose between setting the trait bound for Cap as Clone, Debug or as Integral.
I think the former seems better.

For the Clone trait, it should be sufficient to specify the trait bound and write the impl.
For the Debug trait, discussion is needed regarding the output format.
I think using the debug_struct function for both MfGraph and _Edge should be enough.
@NotLeonian
Copy link
Contributor Author

I misunderstood how derive expansion handles trait bounds.
I think using derive alone is sufficient without debug_struct function.

@NotLeonian NotLeonian linked a pull request Mar 14, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Clone and Debug for MfGraph and _Edge NotLeonian/ac-library-rs
1 participant
@NotLeonian