Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the package name and/or the crate name #47

Closed
qryxip opened this issue Sep 14, 2020 · 9 comments · Fixed by #126
Closed

Rename the package name and/or the crate name #47

qryxip opened this issue Sep 14, 2020 · 9 comments · Fixed by #126

Comments

@qryxip
Copy link
Member

qryxip commented Sep 14, 2020

In Rust, it is common to set a repository name to foo-rs and to set a package.name to foo.

In actual, cargo new strip the "-rs" suffixes until recently.

$ cargo +1.15.1 new foo-rs --lib
note: package will be named `foo`; use --name to override
     Created library `foo-rs` project

Why don't we rename the package name to ac-library or ac_library?

@qryxip
Copy link
Member Author

qryxip commented Sep 14, 2020

Or, or rather and, We can rename the lib.name to "atcoder" or something.

[lib]
name = "atcoder"

Then we can write in this way in examples and integration-tests (if we will write them) .

use atcoder::Dsu;

@koba-e964
Copy link
Collaborator

Agreed on ac_library. I'm afraid that atcoder may give a wrong impression that this crate is officially maintained by AtCoder, which is not quite right.

@TonalidadeHidrica
Copy link
Collaborator

I agree with this suggestion. Do you think we shuold/can change this until 2023/04/07 (deadline of the language update?)

@qryxip
Copy link
Member Author

qryxip commented Mar 29, 2023

I think we should do. Or rather, this is the last chance.

@qryxip
Copy link
Member Author

qryxip commented Mar 29, 2023

I came up with another name. acl.

use acl::FenwickTree;

Repository name: ac-library-rs
package.name: ac-library-rs
lib.name (a.k.a. "crate_name"): ac_library_rsacl

@TonalidadeHidrica
Copy link
Collaborator

TonalidadeHidrica commented Mar 29, 2023

Which name is used in crates.io ? package.name or lib.name? Also I'm not so much in favor of such a short name because it is not very descriptive.

@qryxip
Copy link
Member Author

qryxip commented Mar 29, 2023

package.name.

Example: The default crate_name of xml-rs is xml.

@qryxip
Copy link
Member Author

qryxip commented Mar 29, 2023

@manta1130 @kenkoooo @tttanikawa @hotman78 Mentioning to you as contributors. Would you give us your thoughts?

We have the following choices.

  1. As is

    package.name: ac-library-rs
    lib.name: ac_library_rs

  2. ac-library/ac_library

    package.name: ac-library
    lib.name: ac_library

  3. ac-library-rs/ac_library

    package.name: ac-library-rs
    lib.name: ac_library

  4. atcoder (same as the original ACL)

    package.name: ac-library-rs
    lib.name: atcoder

  5. acl

    package.name: ac-library-rs
    lib.name: acl

@qryxip qryxip changed the title Rename the package name Rename the package name and/or the crate name Mar 30, 2023
@qryxip
Copy link
Member Author

qryxip commented Apr 9, 2023

I created two PRs for 5. and 3.

@mizar Could you choose one and merge it? As I mentioned, today is the last chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants