-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no_std is stable now #45
Conversation
We still need |
However note that removing the |
Hmm I would just bump it. Don't think this crate is ready for 1.0 and less churn until associated Also, is |
I think The reason I added underscores was because |
Alright, makes sense. I'll try |
rust-lang/rust#26775 Ok |
Nevermind, it does work after all. Used that, and bumped version number, so this should be ready to go. |
Travis doesn't seem to agree (see below) |
Ah, I only tested on nightly oops. I'll revert that, and fix the Travis error on the other two where it tries to build with the no_std feature. |
I think you can just do a:
The Edit: Is there away to hide the |
@phil-opp It's needed for tests when |
Looks like CI is failing? Otherwise seems like a good change to me! |
1851532
to
cde2114
Compare
Ok, fixed problems. Also made it always use |
Can you back out the version bump? That's typically done as a separate commit |
Separate PR I assume you mean? Unless I messed up it is a separate commit ATM. |
Yes, separate PR (or I'll just do it when I merge this) |
Sure. I'll just remove the commit then. |
Done! |
Not sure if we still want
__core