-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean target directories after cargo is executed #382
Conversation
@bors r+ |
📌 Commit 7c450a4 has been approved by |
Clean target directories after cargo is executed This PR removes unused files from the target directories after cargo is executed, hopefully saving a lot of disk space on the runners. Thanks to @Eh2406 for providing the list of stuff that's safe to delete!
💔 Test failed - status-travis |
This looks correct to me. In case I was wrong, Is there some way to test this to make sure this does not force a rebuild? Also when you know, can you report back how much time/space this saved? |
7c450a4
to
87472e3
Compare
@bors r+
Not sure how to test this without inspecting cargo's output, and that's something we aren't doing at the moment. It would be easy to notice once deployed though, since build time would increase a lot.
Sure! |
📌 Commit 87472e3 has been approved by |
Clean target directories after cargo is executed This PR removes unused files from the target directories after cargo is executed, hopefully saving a lot of disk space on the runners. Thanks to @Eh2406 for providing the list of stuff that's safe to delete!
Does it make sense to trigger a small crater run that no one cares about, so if this did not work we can back it out without anyone waiting on the results? |
💔 Test failed - status-travis |
Clean target directories after cargo is executed This PR removes unused files from the target directories after cargo is executed, hopefully saving a lot of disk space on the runners. Thanks to @Eh2406 for providing the list of stuff that's safe to delete!
☀️ Test successful - status-appveyor, status-travis |
This PR removes unused files from the target directories after cargo is executed, hopefully saving a lot of disk space on the runners.
Thanks to @Eh2406 for providing the list of stuff that's safe to delete!