Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean target directories after cargo is executed #382

Merged
merged 1 commit into from
Dec 30, 2018

Conversation

pietroalbini
Copy link
Member

This PR removes unused files from the target directories after cargo is executed, hopefully saving a lot of disk space on the runners.

Thanks to @Eh2406 for providing the list of stuff that's safe to delete!

@pietroalbini
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Dec 30, 2018

📌 Commit 7c450a4 has been approved by pietroalbini

bors added a commit that referenced this pull request Dec 30, 2018
Clean target directories after cargo is executed

This PR removes unused files from the target directories after cargo is executed, hopefully saving a lot of disk space on the runners.

Thanks to @Eh2406 for providing the list of stuff that's safe to delete!
@bors
Copy link
Contributor

bors commented Dec 30, 2018

⌛ Testing commit 7c450a4 with merge e78b57c...

@bors
Copy link
Contributor

bors commented Dec 30, 2018

💔 Test failed - status-travis

@Eh2406
Copy link
Contributor

Eh2406 commented Dec 30, 2018

This looks correct to me. In case I was wrong, Is there some way to test this to make sure this does not force a rebuild? Also when you know, can you report back how much time/space this saved?

@pietroalbini
Copy link
Member Author

@bors r+

In case I was wrong, Is there some way to test this to make sure this does not force a rebuild?

Not sure how to test this without inspecting cargo's output, and that's something we aren't doing at the moment. It would be easy to notice once deployed though, since build time would increase a lot.

Also when you know, can you report back how much time/space this saved?

Sure!

@bors
Copy link
Contributor

bors commented Dec 30, 2018

📌 Commit 87472e3 has been approved by pietroalbini

@bors
Copy link
Contributor

bors commented Dec 30, 2018

⌛ Testing commit 87472e3 with merge cac4260...

bors added a commit that referenced this pull request Dec 30, 2018
Clean target directories after cargo is executed

This PR removes unused files from the target directories after cargo is executed, hopefully saving a lot of disk space on the runners.

Thanks to @Eh2406 for providing the list of stuff that's safe to delete!
@Eh2406
Copy link
Contributor

Eh2406 commented Dec 30, 2018

since build time would increase a lot.

Does it make sense to trigger a small crater run that no one cares about, so if this did not work we can back it out without anyone waiting on the results?

@bors
Copy link
Contributor

bors commented Dec 30, 2018

💔 Test failed - status-travis

@pietroalbini
Copy link
Member Author

Failure due to a yanked crate in the blacklist, fixed in #383.

@bors retry

@bors
Copy link
Contributor

bors commented Dec 30, 2018

⌛ Testing commit 87472e3 with merge fa42afa...

bors added a commit that referenced this pull request Dec 30, 2018
Clean target directories after cargo is executed

This PR removes unused files from the target directories after cargo is executed, hopefully saving a lot of disk space on the runners.

Thanks to @Eh2406 for providing the list of stuff that's safe to delete!
@bors
Copy link
Contributor

bors commented Dec 30, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: pietroalbini
Pushing fa42afa to master...

@bors bors merged commit 87472e3 into rust-lang:master Dec 30, 2018
@pietroalbini pietroalbini deleted the clean-target-dir branch January 3, 2019 21:00
pietroalbini added a commit to pietroalbini/crater that referenced this pull request Jan 3, 2019
…r=pietroalbini"

This reverts commit fa42afa, reversing
changes made to 48233a2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants