Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unique feature which doesn't exist anymore #84

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

Bobo1239
Copy link
Contributor

@Bobo1239 Bobo1239 commented Aug 13, 2018

Unique was marked permanently-unstable in rust#46952 and its feature
flag was changed to ptr_internals which we're already using.

See rust-lang/rust#46952.
Required to fix toolstate as rust-lang/rust#52644 introduced an error when an unknown feature is encountered. edit: This would also unblock nightlies.

`Unique` was marked permanently-unstable in rust#46952 and its feature
flag was changed to `ptr_internals` which we're already using.
@RalfJung
Copy link
Member

This would also unblock nightlies.

Nightlies are not blocked when the nomicon is broken. They are only blocked for rustfmt, clippy and rls.

Still, would be nice to get it green again!

Copy link
Member

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@steveklabnik steveklabnik merged commit 29d8ef4 into rust-lang:master Aug 13, 2018
@RalfJung
Copy link
Member

@Bobo1239 do you want to make a PR against rustc to update the nomicon submodule?

@Bobo1239
Copy link
Contributor Author

@RalfJung Sure, that was my initial intention anyways.
Regarding the nightlies: I somehow didn't see that rls was just fixed when I was checking so I assumed that nomicon was the blocker... 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants