Skip to content
This repository has been archived by the owner on Nov 22, 2018. It is now read-only.

Missed regression #4

Closed
Fraser999 opened this issue Oct 10, 2016 · 2 comments
Closed

Missed regression #4

Fraser999 opened this issue Oct 10, 2016 · 2 comments

Comments

@Fraser999
Copy link

When running crater against #36384, the results exposed a regression in our XorName crate.

This crate has been absorbed (more or less verbatim) into our Routing crate which is published on crates.io, and as such I'd have expected a similar regression to have been exposed at https://github.com/maidsafe/routing/blob/master/src/xor_name.rs#L58-L59.

@bluss
Copy link

bluss commented Oct 10, 2016

@Fraser999 The new code will not stop compiling and will not regress because of a minute difference:

The orignal in XorName uses [u8; 64], and the new code uses [u8; 32]. Arrays of size 0-32 inclusive have the needed explicit trait implementations, including Eq.

@Fraser999
Copy link
Author

Ah - of course! Sorry for the bogus report :(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants