Fix an index out of bounds panic in parse_str #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With specific malformed inputs, like:
"F9168C5E-CEB2F4faaFB6BFF329BF39FA1E4"
,parse_str
used to panic with:The problem was in the loop that processes input characters: The loop happily writes all valid characters that aren't group delimiters to a buffer. With some cleverly placed hyphens, it was possible to fool the loop into trying to write more bytes to the buffer than is possible.
This problem was found with cargo-fuzz.