Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

not working for external crates #96

Closed
dvic opened this issue Aug 9, 2018 · 3 comments
Closed

not working for external crates #96

dvic opened this issue Aug 9, 2018 · 3 comments

Comments

@dvic
Copy link

dvic commented Aug 9, 2018

I'm having the same issue as with the Visual Code extension: rust-lang/vscode-rust#391.

Is the extension supposed to work also outside the current crate? E.g., when you click on a method from an external crate, you cannot use goto definition from there.

@dvic dvic changed the title goto definition outside crate not working for external crates Aug 9, 2018
@alexheretic
Copy link
Member

This doesn't currently work as the client lib atom-languageclient filters the current project files before sending events to the language server. It isn't trivial to "know" which files outside the project you should be sending to that project's language server.

But I guess the client could keep a record of file locations received in textDocument/definition responses outside of the project and try to treat them as if they were inside the project.

I'm not sure there are any issues yet for this over there. Development also seems to have paused for the lib...

@dvic
Copy link
Author

dvic commented Aug 14, 2018

Ah good to know! This is then probably also the cause for the same problem in the Visual Code plugin.

@alexheretic
Copy link
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants