Skip to content

Panic on windows7 when resolving an inline #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
roblabla opened this issue Nov 15, 2023 · 1 comment · Fixed by #578
Closed

Panic on windows7 when resolving an inline #577

roblabla opened this issue Nov 15, 2023 · 1 comment · Fixed by #578

Comments

@roblabla
Copy link
Contributor

roblabla commented Nov 15, 2023 •
edited
Loading

Since #569 was merged, Backtrace::resolve panics on Windows 7 due to unwrapping an Option set to None. After some further instrumentation, I was able to find out the source of the problem: Failed to find SymAddrIncludeInlineTrace in dbghelp. This makes the capture::tests::test_frame_conversion unit test fail on Windows 7.

This is because Windows7 ships dbghelp.dll version 6.1, but SymAddrIncludeInlineTrace was added in dbghelp.dll version 6.2.

This affects the Rust stdlib Backtrace as well, see rust-lang/rust#117941
@ChrisDenton
Copy link
Member

Ah, sorry about that. dbghelp.dll version 6.2 does apparently support Windows 7 but isn't distributed with it.

Easiest fix would be to use something like (*dbghelp.dbghelp()).SymAddrIncludeInlineTrace().is_none() to switch back to the old way if the symbol isn't found.

@roblabla roblabla mentioned this issue Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix panic in backtrace symbolication on win7 roblabla/backtrace-rs
2 participants
@roblabla @ChrisDenton