-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSRV regression on Windows #597
Comments
See https://github.com/rust-lang/backtrace-rs?tab=readme-ov-file#supported-rust-versions By that policy the current MSRV is actually 1.75 (or maybe 1.74 since the latest release is still new), it just hasn't been updated elsewhere yet. MSRV is tested but currently only for Linux: backtrace-rs/.github/workflows/main.yml Lines 235 to 244 in 6fa4b85
|
Ah, my apologies. Yes, we need to run the MSRV tests on Windows too, I suppose, but yes, any replacement is allowed to be one that breaks your CI anyways. |
I guess that's fine. It just makes it more difficult to debug when consuming without having the |
I'll try to get a 0.3.71 out the door, it looks like |
0.3.71 is published and 0.3.70 is yanked! |
Thanks! |
We run rustc 1.71.1 in our CI and noticed that the Windows builds started failing yesterday: https://github.com/aws/s2n-quic/actions/runs/8394213178/job/22990857677?pr=2159#step:8:390.
The newest release seems to be using
ptr::from_ref
, which was not stabilized until 1.76.0. However, the documented MSRV in the backtrace crate is 1.65.0:backtrace-rs/Cargo.toml
Line 18 in 6fa4b85
Either we should use something that is compatible with 1.65 or the MSRV needs to be bumped.
I also noticed that the CI does not test against your advertised MSRV:
backtrace-rs/.github/workflows/main.yml
Lines 19 to 36 in 6fa4b85
The text was updated successfully, but these errors were encountered: