Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect field name in chapter 13 #3399

Closed
2 tasks done
infinityfye opened this issue Oct 25, 2022 · 1 comment
Closed
2 tasks done

Incorrect field name in chapter 13 #3399

infinityfye opened this issue Oct 25, 2022 · 1 comment
Milestone

Comments

@infinityfye
Copy link

infinityfye commented Oct 25, 2022

  • I have checked the latest main branch to see if this has already been fixed
  • I have searched existing issues and pull requests for duplicates

URL to the section(s) of the book with this problem:

Description of the problem:
This concerns the IO project from chapter 12 and the improvements applied in chapter 13.
The typo specifically is filename as opposed to file_path when referring to the Config struct field and when referring to the variable in Config::build
In line 31 it is stated that the Config struct field is filename while it is file_path. While in line 121 it is stated that the value is filename while it should be file_path

Suggested fix:
Change both occurrences of filename to file_path.
I would have opened a PR directly, but there is another solution that wouldn't cause a difference with the printed version; to change the linked code in the Config struct definition and in Config::build. This will break compatibility with chapter12, but it's still a viable solution, I think.

@carols10cents carols10cents changed the title Typo in chapter 13 Incorrect field name in chapter 13 Oct 26, 2022
@carols10cents carols10cents added this to the ch13 milestone Oct 26, 2022
@carols10cents
Copy link
Member

Fixed in #3457.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants