Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious sentence in book text #3781

Closed
StefanSalewski opened this issue Nov 19, 2023 · 2 comments
Closed

Spurious sentence in book text #3781

StefanSalewski opened this issue Nov 19, 2023 · 2 comments

Comments

@StefanSalewski
Copy link

The sentence is:

Otherwise, by default, Cargo will only look for versions greater than 0.8.5 and less than 0.9.0.

As discussed in https://users.rust-lang.org/t/cargo-explanation-confusing-in-official-rust-book/102764/2 it would be a good idea to just remove it.

@chriskrycho
Copy link
Contributor

The sentence here is mostly just very far away from the context which makes it make sense (a dozen paragraphs earlier!), but you’re right that it is also slightly confused! It should probably be rephrased, rather than dropped. Instead of “Otherwise, by default, …” we could have something like “With rand = "0.8.5" in Cargo.toml, …” and the rest of the sentence works.

@chriskrycho chriskrycho added this to the ch2 milestone Mar 29, 2024
@chriskrycho
Copy link
Contributor

This was fixed in #3882, and I didn’t realize this issue and #3541 overlapped. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants