Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the PR author to r- #32

Open
tgross35 opened this issue Jul 4, 2023 · 1 comment
Open

Allow the PR author to r- #32

tgross35 opened this issue Jul 4, 2023 · 1 comment

Comments

@tgross35
Copy link

tgross35 commented Jul 4, 2023

It doesn't come up too often, but I have seen cases where the author realizes they need to make a change after approval. In these cases it would be nice if they could do it right away, without waiting for somebody to do it for them, or to push a dummy commit.

The power in this command is to kill a rollup, but I think abuse potential is pretty low. Better to waste a rollup than to let a whoops into master.

(this may already be current behavior, I haven't looked into it)

@Kobzol
Copy link
Contributor

Kobzol commented Jul 4, 2023

(this may already be current behavior, I haven't looked into it)

Well, it's certainly not the current behavior of this bot, because it doesn't implement any approvals or merge queue stuff :D Not sure about homu.

This sounds reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants