Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic end-date calculation fails during promotion window #247

Closed
ehuss opened this issue Jan 20, 2023 · 0 comments · Fixed by #325
Closed

Automatic end-date calculation fails during promotion window #247

ehuss opened this issue Jan 20, 2023 · 0 comments · Fixed by #325
Labels
A-bisection-algorithm Area: The bisection algorithm bug Something isn't working

Comments

@ehuss
Copy link
Collaborator

ehuss commented Jan 20, 2023

If the --end date is not specified, then cargo-bisect-rustc will assume the end date is today. However, there is a window of an hour or so from UTC midnight until nightly gets published that this will result in an error:

ERROR: Could not find nightly-2023-01-20; url: https://static.rust-lang.org/dist/2023-01-20/rustc-nightly-x86_64-apple-darwin.tar.gz

I think it would be good if when --end is not specified that cargo-bisect-rustc would walk back from "today" at least a few days to find a nightly that exists. There is already code for it to skip over missing nightlies while bisecting. I'm not sure if there is something that can be reused, or if there are other options.

cargo-bisect-rustc 0.6.5

@ehuss ehuss added bug Something isn't working A-bisection-algorithm Area: The bisection algorithm labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-bisection-algorithm Area: The bisection algorithm bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant