Skip to content

Commit 142c49d

Browse files
committed
no need to clone I don't think here.
1 parent b4ab730 commit 142c49d

File tree

1 file changed

+10
-15
lines changed

1 file changed

+10
-15
lines changed

src/cargo/ops/cargo_test.rs

+10-15
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,6 @@ fn run_unit_tests(
8484
script_meta,
8585
} in compilation.tests.iter()
8686
{
87-
let test = unit.target.name().to_string();
88-
8987
let test_path = unit.target.src_path().path().unwrap();
9088
let exe_display = if let TargetKind::Test = unit.target.kind() {
9189
format!(
@@ -117,20 +115,17 @@ fn run_unit_tests(
117115

118116
let result = cmd.exec();
119117

120-
match result {
121-
Err(e) => {
122-
let e = e.downcast::<ProcessError>()?;
123-
errors.push((
124-
unit.target.kind().clone(),
125-
test.clone(),
126-
unit.pkg.name().to_string(),
127-
e,
128-
));
129-
if !options.no_fail_fast {
130-
break;
131-
}
118+
if let Err(e) = result {
119+
let e = e.downcast::<ProcessError>()?;
120+
errors.push((
121+
unit.target.kind().clone(),
122+
unit.target.name().to_string(),
123+
unit.pkg.name().to_string(),
124+
e,
125+
));
126+
if !options.no_fail_fast {
127+
break;
132128
}
133-
Ok(()) => {}
134129
}
135130
}
136131

0 commit comments

Comments
 (0)