fix: deduplicate crate types in cargo rustc command to prevent filename collisions

Author: Frank-III

src/bin/cargo/commands/rustc.rs

@@ -92,14 +92,17 @@ pub fn exec(gctx: &mut GlobalContext, args: &ArgMatches) -> CliResult {
         return Ok(());
     }
 
-    let crate_types = args
-        .get_many::<String>(CRATE_TYPE_ARG_NAME)
-        .into_iter()
-        .flatten()
-        .flat_map(|s| s.split(','))
-        .filter(|s| !s.is_empty())
-        .map(String::from)
-        .collect::<Vec<String>>();
+    let crate_types = {
+        let mut seen = std::collections::HashSet::new();
+        args.get_many::<String>(CRATE_TYPE_ARG_NAME)
+            .into_iter()
+            .flatten()
+            .flat_map(|s| s.split(','))
+            .filter(|s| !s.is_empty())
+            .map(String::from)
+            .filter(|s| seen.insert(s.clone()))
+            .collect::<Vec<String>>()
+    };
 
     compile_opts.target_rustc_crate_types = if crate_types.is_empty() {
         None

tests/testsuite/rustc.rs

@@ -855,3 +855,18 @@ fn precedence() {
 "#]])
         .run();
 }
+
+#[cargo_test]
+fn build_with_duplicate_crate_types() {
+    let p = project().file("src/lib.rs", "").build();
+
+    // Test with duplicate crate types specified directly
+    p.cargo("rustc -v --crate-type staticlib --crate-type staticlib")
+        .with_stderr_data(str![[r#"
+[COMPILING] foo v0.0.1 ([ROOT]/foo)
+[RUNNING] `rustc --crate-name foo --edition=2015 src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type staticlib --emit=dep-info,link -C embed-bitcode=no -C debuginfo=2 -C split-debuginfo=unpacked --check-cfg 'cfg(docsrs,test)' --check-cfg 'cfg(feature, values())' -C metadata=991ef8c99cd510e0 -C extra-filename=-f0d97c77b50b1fb3 --out-dir [ROOT]/foo/target/debug/deps -L dependency=[ROOT]/foo/target/debug/deps`
+[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s
+
+"#]])
+        .run();
+}