Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of #11851 - weihanglo:make-cargo-a-workspace, r=ehuss
Make cargo a workspace ### What does this PR try to resolve? The first step of making cargo a workspace. Benefits: * Dogfooding ourselves. * Unblock #11831: It got stuck because the new version of tempfile using `windows-sys` but some issues haven't yet be solved in rust-lang/rust. * Make `cargo xtask` or similar developer workflow possible (e.g., #11717) * Having our own Cargo.lock, so our CI can cover the exact binary going to ship. Also free Cargo from CI breaks due to dependency patch releases. * Probably more? Please add them by yourself. ### How should we test and review this PR? Please review it commit by commit. A companion PR is here rust-lang/rust#109133, and should be reviewed together. ### Unresolved issues To limit the scope of this pull request, the following issues are intentionally left unresolved. They will be addressed right after this pull request gets merged. - [x] Make `benches/capture` and `benches/capture` workspace members. (Addressed with 2cf9718) - [x] Make `crates/resolver-tests` a workspace member. (Addressed with #11886) - [ ] ~~Fix clippy warnings and re-enable clippy check in CI for all workspace members.~~ - Blocked on rust-lang/rfcs#3389 so we can more easily propagate our clippy settings - [ ] Fix rustdoc warnings and re-enable rustdoc check in CI for all workspace members. - [ ] Fix `linkchecker.sh` warnings in CI (#11851 (comment)) - [ ] Leverage workspace flag `--workspace` when running `cargo build` or `cargo test`, instead of using flag `-p`. - [ ] Leverage glob syntax when probing members in `[workspace]` in Cargo.toml (i.e., `crates/*`). ### Additional information This depends on prior works from `@Muscraft` and `@ehuss.` Credits to them!
- Loading branch information